Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 261413 - o.e.team.svn.core has hard dependency to com.ibm.icu bundle
Summary: o.e.team.svn.core has hard dependency to com.ibm.icu bundle
Status: RESOLVED FIXED
Alias: None
Product: Subversive
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Igor Burilo CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-17 12:44 EST by Thomas Hallgren CLA
Modified: 2011-05-17 14:17 EDT (History)
0 users

See Also:


Attachments
Patch that removes the dependency (490 bytes, patch)
2009-01-17 13:02 EST, Thomas Hallgren CLA
no flags Details | Diff
Patch that replaces the dependency with package imports (1.39 KB, patch)
2009-01-17 19:33 EST, Thomas Hallgren CLA
i.vinnykov: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Hallgren CLA 2009-01-17 12:44:32 EST
The bundle org.eclipse.team.svn.core has a hard dependency to the com.ibm.icu bundle. Please replace this "Require-Bundle" declaration with "Import-Package" declarations for com.ibm.icu.text and com.ibm.icu.util.

The reason for this is that a hard requirement on the bundle will force deployments to include the fairly huge full bundle (over 2MB) instead of the minimalistic com.ibm.icu.base.

The huge bundle is in most cases completely unnecessary when running a modern JVM (Java 1.6) since most of its functionality has been merged in to the JVM runtime.
Comment 1 Thomas Hallgren CLA 2009-01-17 13:02:11 EST
Created attachment 122859 [details]
Patch that removes the dependency

Apparently, the dependency is not currently used so this patch just removes it.
Comment 2 Thomas Hallgren CLA 2009-01-17 19:33:26 EST
Created attachment 122868 [details]
Patch that replaces the dependency with package imports

The previous patch was flawed. My IDE didn't rebuild properly so I missed the actual usage of com.ibm.icu.

This patch replaces the bundle requirement with imported packages. It also removes the StringId.isStringId() method since it references the com.ibm.icu.lang package which for some reason is not present in the com.ibm.icu.base bundle. The StringId.isStringId() is not referenced from any of the team.svn bundles.
Comment 3 Igor Burilo CLA 2009-01-22 04:41:10 EST
(In reply to comment #2)
> Created an attachment (id=122868)
> Patch that replaces the dependency with package imports
> 
> The previous patch was flawed. My IDE didn't rebuild properly so I missed the
> actual usage of com.ibm.icu.
> 
> This patch replaces the bundle requirement with imported packages. It also
> removes the StringId.isStringId() method since it references the
> com.ibm.icu.lang package which for some reason is not present in the
> com.ibm.icu.base bundle. The StringId.isStringId() is not referenced from any of
> the team.svn bundles.

Thomas, I applied your patch, thanks a lot.
I also removed strong dependency to com.ibm.icu from UI plugin