This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 261243 - MANIFEST.MF generated with size 65536
Summary: MANIFEST.MF generated with size 65536
Status: CLOSED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: jst.server (show other bugs)
Version: 3.1   Edit
Hardware: PC All
: P3 critical (vote)
Target Milestone: 3.1 M5   Edit
Assignee: Angel Vera CLA
QA Contact: Tim deBoer CLA
URL:
Whiteboard:
Keywords:
: 257690 257691 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-01-15 13:52 EST by Kaloyan Raev CLA
Modified: 2017-10-11 16:27 EDT (History)
5 users (show)

See Also:

Attachments
patch for 3.1 (911 bytes, patch)
2009-02-05 15:56 EST, Jason Sholl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2009-01-15 13:52:36 EST 
Build: I-3.1-20090115084946

Steps to reproduce:
1. Create an EAR project. 
2. Create a Web project. 
3. Add the Web project to the EAR project. 
4. Deploy the project on a server. 

Result: The EAR cannot be deployed, because of "invalid manifest file". 

The MANIFEST.MF of the generated EAR is OK, but the one in the WAR inside the EAR has size 65536 bytes (trailing NULs). 

I was able to reproduce this with Glassfish and JBoss, therefore I assume this is not a problem in the server adapter, but in the WTP code. 

EARs produced with the Export wizard are OK and deploys fine, if done manually.
Comment 1 Kaloyan Raev CLA 2009-01-15 13:57:04 EST 
I noticed this "invalid manifest file" just before Christmas both on 3.1 and 3.0.x, but had no time to dig into it. 

It is important coincidence that at that time my dev system was upgraded from WinXP to Vista. I haven't seen this problem on WinXP before. So, it might relate to the OS.
Comment 2 David Williams CLA 2009-01-15 14:49:24 EST 
Do you think this could have been fixed by bug 248674?
Comment 3 Carl Anderson CLA 2009-01-15 14:52:07 EST 
Jason, it looks like this may be Vista-specific, and may need a fix for 3.0.4
as well.

Kaloyan - Are the projects EE 5?  Or older?
Comment 4 Kaloyan Raev CLA 2009-01-16 03:37:11 EST 
This affects both J2EE 1.4 and Java EE 5 projects. 
I was not able to reproduce this problem with WTP 3.0.2. 
I have tried to revert the patch from bug 248674, but this did not help.
Comment 5 Jason Sholl CLA 2009-01-16 12:19:51 EST 
Kaloyan,

Does this also happen with the latest 3.0.4 drivers?  I'd rather dig into it there and role the fix forward into 3.1 than fix it in 3.1 and then have to role the fix back to 3.0.4 in the future.
Comment 6 Kaloyan Raev CLA 2009-01-19 05:06:41 EST 
Jason, I was not able to reproduce the issue with the latest 3.0.4 build - M-3.0.4-20090117150137. 
However, it is still reproducible with the latest 3.1 I-build - I-3.1-20090115155552.
Comment 7 kiril mitov CLA 2009-02-03 05:10:47 EST 
Reproduced on gentoo linux. Changing the OS to All
Comment 8 Jason Sholl CLA 2009-02-05 15:56:54 EST 
Created attachment 124882 [details]
patch for 3.1
Comment 9 Angel Vera CLA 2009-02-05 16:48:01 EST 
Thanks for the patch Jason and the testing. I will include it right away.
Comment 10 Angel Vera CLA 2009-02-05 17:00:38 EST 
I talked to David and Tim. Tim reviewed the changes and he is okay with them.  David agrees with releasing the changes right away, since this is a critical bug.

Changes released to HEAD. 

Adding Gorken as a FYI.
Comment 11 Angel Vera CLA 2009-02-05 17:06:22 EST 
*** Bug 257691 has been marked as a duplicate of this bug. ***
Comment 12 Angel Vera CLA 2009-02-05 17:07:54 EST 
*** Bug 257690 has been marked as a duplicate of this bug. ***
Comment 13 Kaloyan Raev CLA 2009-02-06 04:33:30 EST 
Verified with S-3.1M5-20090206011619.
Comment 14 Eclipse Genie CLA 2017-10-11 16:27:16 EDT 
New Gerrit change created: https://git.eclipse.org/r/108732