Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 260537 - Activity management support
Summary: Activity management support
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: dev   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: 3.2   Edit
Assignee: Hiroyuki CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 163537 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-01-09 07:20 EST by Hiroyuki CLA
Modified: 2009-04-29 23:17 EDT (History)
2 users (show)

See Also:


Attachments
screenshot.png (173.33 KB, image/png)
2009-01-09 07:21 EST, Hiroyuki CLA
no flags Details
org.eclipse.mylyn.patch (2.92 KB, patch)
2009-01-09 08:00 EST, Hiroyuki CLA
no flags Details | Diff
org.eclipse.mylyn.extras.zip (5.60 KB, application/octet-stream)
2009-01-09 08:01 EST, Hiroyuki CLA
no flags Details
org.eclipse.mylyn.experimental.zip (5.94 KB, application/octet-stream)
2009-01-09 08:02 EST, Hiroyuki CLA
no flags Details
mylyn-features.patch (6.43 KB, patch)
2009-01-09 08:24 EST, Hiroyuki CLA
no flags Details | Diff
extension_ids.patch (1.59 KB, patch)
2009-01-09 08:28 EST, Hiroyuki CLA
no flags Details | Diff
plugin_ver.patch (567 bytes, patch)
2009-01-09 08:35 EST, Hiroyuki CLA
no flags Details | Diff
org.eclipse.mylyn.task.core.patch (2.29 KB, patch)
2009-01-09 08:39 EST, Hiroyuki CLA
no flags Details | Diff
org.eclipse.mylyn.task.ui.patch (30.97 KB, patch)
2009-01-09 08:40 EST, Hiroyuki CLA
no flags Details | Diff
org.eclipse.mylyn.sandbox.ui.patch (2.48 KB, patch)
2009-01-09 09:43 EST, Hiroyuki CLA
no flags Details | Diff
similar approach for tasks.ui (14.28 KB, patch)
2009-04-29 04:03 EDT, Steffen Pingel CLA
no flags Details | Diff
mylyn/context/zip (42.15 KB, application/octet-stream)
2009-04-29 04:03 EDT, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hiroyuki CLA 2009-01-09 07:20:08 EST
I hope for the support of the activity management for Mylyn function and connector

- The activity management of Connector
- The activity management of Task Presentation action
- The activity management of Help contents part (Wikitext only).
- The activity management of menu action (Sub-menu).
Comment 1 Hiroyuki CLA 2009-01-09 07:21:22 EST
Created attachment 122093 [details]
screenshot.png
Comment 2 Hiroyuki CLA 2009-01-09 08:00:15 EST
Created attachment 122096 [details]
org.eclipse.mylyn.patch

It is necessary to describe the extension definition for the activity in the plug-in. 

A base activity definition is described in org.eclipse.mylyn plug-in.
Two another plug-ins are necessary so that three release packages may exist.
Comment 3 Hiroyuki CLA 2009-01-09 08:01:36 EST
Created attachment 122097 [details]
org.eclipse.mylyn.extras.zip

One is for org.eclipse.mylyn.extras-sdk feature in Mylyn Extras package.
New project => org.eclipse.mylyn.extras plug-in is made.
Comment 4 Hiroyuki CLA 2009-01-09 08:02:28 EST
Created attachment 122098 [details]
org.eclipse.mylyn.experimental.zip

Another is for org.eclipse.mylyn.experimental-sdk feature in Mylyn Incubator package.
New project = org.eclipse.mylyn.experimental plug-in is made.
Comment 5 Hiroyuki CLA 2009-01-09 08:24:52 EST
Created attachment 122100 [details]
mylyn-features.patch

The plug-in corresponding to Mylyn Extras and Incubatorn features are changed.
Comment 6 Hiroyuki CLA 2009-01-09 08:28:25 EST
Created attachment 122101 [details]
extension_ids.patch

Necessary extension id is defined for the activity management.
Comment 7 Hiroyuki CLA 2009-01-09 08:35:42 EST
Created attachment 122102 [details]
plugin_ver.patch

The eclipse version of the plug-in is changed for the activity control.
How to handle extension id is different in the case of 3.0 and 3.2.
 It match to another plug-in with it so that how to handle extension id may become the same.
Comment 8 Hiroyuki CLA 2009-01-09 08:39:40 EST
Created attachment 122103 [details]
org.eclipse.mylyn.task.core.patch

The processing of the activity management is added.
Comment 9 Hiroyuki CLA 2009-01-09 08:40:11 EST
Created attachment 122104 [details]
org.eclipse.mylyn.task.ui.patch

The processing of the activity management is added.
Comment 10 Hiroyuki CLA 2009-01-09 09:43:00 EST
Created attachment 122116 [details]
org.eclipse.mylyn.sandbox.ui.patch

The processing of the activity management is added.
Comment 11 Steffen Pingel CLA 2009-01-09 19:38:10 EST
Thanks Hiroyuki. I'll need some time to review and understand how activities work. I have scheduled this bug for 3.2 so we can get to it in time for Galileo.
Comment 12 Steffen Pingel CLA 2009-01-11 17:39:59 EST
*** Bug 163537 has been marked as a duplicate of this bug. ***
Comment 13 Hiroyuki CLA 2009-01-20 08:06:42 EST
The bug was found to the activity management, and reported. 

Bug 261622 View shortcut is displayed in the Show View's sub-menu if the activity was disabled

"Task List" is displayed in the sub-menu of "Window" > "Show View"
when the all activity definition (include org.eclipse.mylyn.task.ui) of Mylyn is disabled.
Comment 14 Steffen Pingel CLA 2009-04-29 04:03:28 EDT
Created attachment 133707 [details]
similar approach for tasks.ui
Comment 15 Steffen Pingel CLA 2009-04-29 04:03:30 EDT
Created attachment 133708 [details]
mylyn/context/zip
Comment 16 Steffen Pingel CLA 2009-04-29 04:09:59 EDT
Thanks for your efforts Hiroyuki! This helped a lot to understand Capabilities.

I have taken a similar approach in my patch to comply with the Galileo Capability requirement. I haven't enabled capability checking for connector contributions since we don't have a good story for hiding those in all applicable places. Tasks would still show in the task list and most other integrations points such as hyperlinking, duplicate detection, sychronizations etc. would still also apply. If there is a use case for installing a connector and not making it visible in the UI we can reconsider.   

I didn't apply the changes for IDynamicSubMenuContributor since the extension point is only intended for internal use and should be replaced with the corresponding platform extension mechanism (e.g. the org.eclipse.menu extension point).  
Comment 17 Hiroyuki CLA 2009-04-29 06:55:49 EDT
Which plug-in was defined as follows ?
- category definition 
- categoryActivityBinding
- defaultEnablement
- activityPatternBinding for sandbox.ui and monitor.usage 
Comment 18 Hiroyuki CLA 2009-04-29 07:17:08 EDT
When the WikiText activity is disabled, the kind of WikiText editor is displayed in the editor selection part of the repository setting. 

WorkbenchUtil.allowUseOf method support IPluginContribution and String only.
Therefore,  " if (WorkbenchUtil.allowUseOf(extension)) " is true always.
Comment 19 Hiroyuki CLA 2009-04-29 07:59:19 EDT
I think that you should define the dependence of the activity. 

		<activityRequirementBinding
    	    activityId="org.eclipse.mylyn.capabilities.taskFocusedInterface"
	        requiredActivityId="org.eclipse.mylyn.capabilities.taskManagement" />
Comment 20 Hiroyuki CLA 2009-04-29 08:05:59 EDT
(In reply to comment #17)
> Which plug-in was defined as follows ?
> - category definition
> - categoryActivityBinding
> - defaultEnablement

The definition above was found. 

dev.eclipse.org:/cvsroot/callisto / org.eclipse.galileo

Is rg.eclipse.galileo included in Eclipse SDK (Eclipse Classic) ?
I think that all activities of Mylyn enter the state that cannot be used
when rg.eclipse.galileo is not included. 
Comment 21 Hiroyuki CLA 2009-04-29 10:04:57 EDT
If the task editor is opened when all Mylyn Activity is disabled, the AssertionFailedException is generated. 

This is due to the following modifications. 

			if (pageFactory.canCreatePageFor(getTaskEditorInput()) && WorkbenchUtil.allowUseOf(pageFactory)) {

No page is made.
Then, setActivePage(0) was executed.
And, the AssertionFailedException was occurred. 
		
Comment 22 Steffen Pingel CLA 2009-04-29 13:29:49 EDT
You have raised valid point Hiroyuki. Following the Galileo requirements all category definitions and bindings are part of the org.eclipse.galileo plug-in. The Mylyn capabilities plug-in is only distributed as part of Galileo so the default enablement should not be a problem.

The failing task editor is not great and needs better error handling. At the moment disabling the Task Management capability and still using the Task Editor and Task List is unsupported.
Comment 23 Hiroyuki CLA 2009-04-29 18:38:05 EDT
There is one question. 
The reason that the following do not define?

- sandbox.ui plug-in
- monitor.usage plug-in
Comment 24 Hiroyuki CLA 2009-04-29 18:41:28 EDT
And, Please judge whether comment #18 is a bug.
Comment 25 Steffen Pingel CLA 2009-04-29 19:54:57 EDT
I missed comment 18. Reopening to investigate that.

We currently don't have a driver to support capabilities for sandbox plug-ins as these are not distributed as part of Galileo. Do you have a requirement for those capabilities?
Comment 26 Steffen Pingel CLA 2009-04-29 23:17:09 EDT
Fixed bug pointed out in comment 18.