Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 260060 - [plug-in registry] show different icons for built-in service properties
Summary: [plug-in registry] show different icons for built-in service properties
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-06 11:28 EST by Wolfgang Schell CLA
Modified: 2009-01-07 10:36 EST (History)
1 user (show)

See Also:

Attachments
pde-runtime-serviceproperties-5-sorting-icons.patch (5.56 KB, patch)
2009-01-06 11:28 EST, Wolfgang Schell CLA 		caniszczyk: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Schell CLA 2009-01-06 11:28:48 EST 
Created attachment 121645 [details]
pde-runtime-serviceproperties-5-sorting-icons.patch

Build ID: I20081211-1908

Steps To Reproduce:
(after patch for bug #259348 has been applied)

1. Launch Eclipse with empty workspace
2. Open the PDE Plugin Registry
3. Locate the OSGi service "org.eclipse.equinox.app.IApplicationContext" in the Plugin Registry

-> Built-in service properties like "objectClass", "service.*" and "component.*" (for Declarative Services) can not easily distingished from user-provided service properties. 

More information:
The supplied patch sorts service properties in the following order (see also bug #259348) and provides an indicator for built-in service properties:

1. "objectClass" (icon is "class_obj.gif")
2. "component.*" (sorted alphabetically, icon has overlay "run_co.gif")
3. "service.*" (sorted alphabetically, icon has overlay "run_co.gif")
4. everything else (sorted alphabetically)

Sorting works as soon as bug #260055 is resolved.

The patch is based on the changes after bug #220110.
Comment 1 Chris Aniszczyk CLA 2009-01-06 11:49:21 EST 
Thanks!
Comment 2 Chris Aniszczyk CLA 2009-01-06 11:49:52 EST 
done.

> 20090106

I used a different icon overlay :)
Comment 3 Wolfgang Schell CLA 2009-01-07 02:47:50 EST 
Hi Chris,

I see, you didn't apply the sorting part for service properties with sorting meaning pushing built-in properties to the top. Was this deliberately?
Comment 4 Chris Aniszczyk CLA 2009-01-07 10:36:43 EST 
Thanks Wolfgang, my mistake.

> 20090107