Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 259882 - [registry] view does not react to changes when filter is on
Summary: [registry] view does not react to changes when filter is on
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 24521
Blocks:
  Show dependency tree
 
Reported: 2009-01-03 04:36 EST by Wassim Melhem CLA
Modified: 2009-01-13 19:25 EST (History)
1 user (show)

See Also:

Attachments
patch (2.07 KB, patch)
2009-01-12 10:34 EST, Jacek Pospychala CLA 		no flags Details | Diff
patch against updated HEAD (2.07 KB, patch)
2009-01-13 11:35 EST, Jacek Pospychala CLA 		caniszczyk: iplog+
Details | Diff
mylyn/context/zip (1.09 KB, application/octet-stream)
2009-01-13 11:42 EST, Chris Aniszczyk CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2009-01-03 04:36:49 EST 
Build: 3.4

1. Fresh workspace.  Java perspective open.
2. Open the Plug-in Registry view and check the 'Show Active Plug-ins Only' option in its drop down menu.
3. Open the Preferences dialog and select to the Plug-in Development/API Baselines preference page.

At this point, the Plug-in Registry view should update automatically to show that the org.eclipse.pde.api.tool.ui plug-in has been activated.

But it doesn't.  You have to refresh the view manually from the toolbar to see that it has become active.

Note that if the 'Show Active Plug-in Only' filter is off, the icons update automatically  and show the green overlay on top of the api.tools.ui plug-in without the need for an explicit refresh.
Comment 1 Jacek Pospychala CLA 2009-01-05 03:14:33 EST 
nice catch Wassim. I'll check that with 3.5 as there was some work around keeping registry up-to-date.
Comment 2 Jacek Pospychala CLA 2009-01-05 05:38:38 EST 
Problem is still in 3.5. It's because bundle state change triggers TreeViewer.refresh(bundle) call, but refresh doesn't work if item is not found (e.g. filtered). This is similar to bug 187200 however it's related to filtered tree filter, whereas here structured tree filters are involved.
Comment 3 Jacek Pospychala CLA 2009-01-05 06:00:41 EST 
duplicate of bug 24521
Comment 4 Wassim Melhem CLA 2009-01-05 12:22:15 EST 
That certainly seems to be the problem.  Thanks for looking into it, Jacek.
Comment 5 Jacek Pospychala CLA 2009-01-12 10:33:03 EST 
(In reply to comment #3)
> duplicate of bug 24521

ok, I learned there to call TreeViewer.refresh(getParent(object)) instead of TreeViewer.refresh(object) when filters are enabled. 
After some testing, it doesn't seem to have any bad performance effects.
Comment 6 Jacek Pospychala CLA 2009-01-12 10:34:20 EST 
Created attachment 122272 [details]
patch

With this patch issue described by Wassim doesn't happen any more :D
Comment 7 Chris Aniszczyk CLA 2009-01-12 15:48:24 EST 
Jacek, the patch doesn't apply cleanly anymore.
Comment 8 Jacek Pospychala CLA 2009-01-13 11:35:32 EST 
Created attachment 122422 [details]
patch against updated HEAD

updated patch
Comment 9 Chris Aniszczyk CLA 2009-01-13 11:42:39 EST 
done.

> 20090113

Thanks Jacek!
Comment 10 Chris Aniszczyk CLA 2009-01-13 11:42:45 EST 
Created attachment 122426 [details]
mylyn/context/zip
Comment 11 Wassim Melhem CLA 2009-01-13 19:25:39 EST 
Thanks Jacek.

May you never dine by yourself like a loser ;)