Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 259094 - [Markers] QuickFixPage should take advantage of IMarkerResolution2#getImage()
Summary: [Markers] QuickFixPage should take advantage of IMarkerResolution2#getImage()
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 326000
  Show dependency tree
 
Reported: 2008-12-17 08:36 EST by Benjamin Cabé CLA
Modified: 2010-10-26 06:12 EDT (History)
5 users (show)

See Also:

Attachments
Patch against o.e.ui.ide (11.92 KB, patch)
2008-12-17 08:38 EST, Benjamin Cabé CLA 		no flags Details | Diff
Patch (11.39 KB, patch)
2009-02-04 07:05 EST, Hitesh CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Cabé CLA 2008-12-17 08:36:57 EST 
That would be cool if the QuickFixPage of the QuickFixWizard would display the image which is -eventually- associated to the marker resolution in the list of the suggested resolutions.
I will attach a patch.

As a side note, that would be even better to also support getDescription() but it's a bit harder since getDescription sometimes is a simple string (PDE), and sometimes is in HTML (JDT)...
Comment 1 Benjamin Cabé CLA 2008-12-17 08:38:47 EST 
Created attachment 120688 [details]
Patch against o.e.ui.ide

note that I've also renamed the resolutionsList attribute to resolutionsViewer
Comment 2 Hitesh CLA 2009-02-04 07:05:34 EST 
Created attachment 124663 [details]
Patch

The patch looks good.I have added an index check to the array  while setting the initial selection, just in case the 'resolutions' map is empty.
Comment 3 Eric Moffatt CLA 2009-02-06 08:50:15 EST 
Adding Kevin for review...

What, if any, are the IP issues here?
Comment 4 Benjamin Cabé CLA 2009-02-06 11:11:17 EST 
(In reply to comment #3)
> What, if any, are the IP issues here?

Eric, I'm a committer!
Comment 5 Eric Moffatt CLA 2009-02-09 10:17:42 EST 
As they say on Saturday Night Live..."never mind"...;-).
Comment 6 Dani Megert CLA 2010-10-13 04:50:30 EDT 
Taking this in light of bug 326000.
Comment 7 Dani Megert CLA 2010-10-13 07:33:27 EDT 
Fixed in org.eclipse.ui.internal.views.markers.QuickFixPage rev. 1.7 without using one of the attached patches.
Comment 8 Deepak Azad CLA 2010-10-26 06:12:43 EDT 
Verified for 3.7M3 on Linux-GTK with I20101025-1800.