Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 258988 - [mirror] p2 mirroring app incorrectly reports warnings
Summary: [mirror] p2 mirroring app incorrectly reports warnings
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P4 minor (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Matthew Piggott CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-16 13:20 EST by Martin Oberhuber CLA
Modified: 2009-03-15 20:47 EDT (History)
2 users (show)

See Also:

Attachments
.log file with INFO messages (1.63 MB, text/x-log)
2008-12-16 13:20 EST, Martin Oberhuber CLA 		no flags Details
MirrorApplication patch (2.45 KB, patch)
2009-02-26 11:36 EST, Matthew Piggott CLA 		pascal: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2008-12-16 13:20:27 EST 
Created attachment 120615 [details]
.log file with INFO messages

Eclipse-SDK-3.5m4
See bug 258680 for the exact *.bat file with my test case

1. Run artifact mirroring, cancel it somewhere in the middle
2. Re-run the same mirroring (with implicit -append)

When done, the mirroring app reports this:

Mirroring completed with warnings and/or errors. Please check log file for more
information.
Log file location: D:\Download\devtools\Eclipse\3.5-I-new\ws\.metadata\.log

But looking at the log (attached), there are neither warnings nor errors. There are only "Info" severity messages that some items to be mirrored had already existed in the target repository. This bears two areas for improvement:

1. The final message should not mention errors / warnings if there have 
   only info severities been logged.
2. The info severities should not carry a stack backtrace which just blows
   up the logfile unnecessarily.
Comment 1 Matthew Piggott CLA 2009-02-26 11:36:10 EST 
Created attachment 126868 [details]
MirrorApplication patch

The verbose output option causes the MirrorApplication to log Warning and Info statuses, otherwise only an Error Status is kept.

To cleanup the output I've removed the exception from the "file exist" Info Status, and added the following message if mirroring completed with an 
Info status:  "Mirroring completed. Please check log file for more information."
Comment 2 Pascal Rapicault CLA 2009-03-15 20:47:18 EDT 
fixed in HEAD