Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 258962 - [composite repo] Does lazily loading children violate contract with UI?
Summary: [composite repo] Does lazily loading children violate contract with UI?
Status: RESOLVED DUPLICATE of bug 256364
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: P2 Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-16 11:10 EST by Andrew Cattle CLA
Modified: 2008-12-16 12:25 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cattle CLA 2008-12-16 11:10:07 EST
I remember discussing this in a p2 call but I can't seem to find where the discussion has been captured in the minutes. I'm logging this bug before it is forgotten.

Currently, composite repositories lazily load their children. However, it is my understanding that part of the contract with UI is that a repository must be finished loading before it can be displayed for efficiency reasons. However, I'm worried that loading all children at the composite's load time and storing them as IRepostiory objects might have a greater chance of leading to synchronization issues than loading them right before use as this would move them outside of the RepositoryManager.

This results in two questions:
1) What does it mean for a composite repo to be loaded? Just the repo or the repo + children?
2) How should composite repos handle the failed loading of a child?

Currently we log the failure and just continue with the next repo. While this increases robustness, it leaves us int he situation where the same repository, without changing it's own content, which have different results each time a method such as "getArtifactKeys()" is called depending on what children are loaded. Perhaps we create a property which says whether or not we care?
Comment 1 Susan McCourt CLA 2008-12-16 12:25:50 EST
I captured that p2 call discussion in bug #256364 and will copy your specific remarks over there...

*** This bug has been marked as a duplicate of bug 256364 ***