Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 258961 - Wrong Message Bundle Reference in ActivityMessages
Summary: Wrong Message Bundle Reference in ActivityMessages
Status: RESOLVED FIXED
Alias: None
Product: RAP
Classification: RT
Component: Workbench (show other bugs)
Version: 1.2   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 1.2 M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-16 10:53 EST by Austin Riddle CLA
Modified: 2008-12-17 11:00 EST (History)
0 users

See Also:


Attachments
Patch with changed code (1.07 KB, patch)
2008-12-16 10:53 EST, Austin Riddle CLA
ruediger.herrmann: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Austin Riddle CLA 2008-12-16 10:53:38 EST
Created attachment 120599 [details]
Patch with changed code

Build ID: CVS HEAD

The class org.eclipse.ui.internal.activities.ws.ActivityMessages.java
has a reference to org.eclipse.ui.internal.WorkbenchMessages in the get() method:

public static ActivityMessages get() {
      Class clazz = WorkbenchMessages.class;
      Object result = RWT.NLS.getISO8859_1Encoded( BUNDLE_NAME, clazz );
      return ( ActivityMessages )result;
    }

This causes multiple exceptions when the activity manager fires a change event.

Should it not be set to Class clazz = ActivityMessages.class; ?

Exception received:

java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key BundleSigningTray_Cant_Find_Service
at java.util.ResourceBundle.getObject(ResourceBundle.java:386)
at java.util.ResourceBundle.getString(ResourceBundle.java:346)
at org.eclipse.rwt.RWT$NLS.internalGet(RWT.java:144)
at org.eclipse.rwt.RWT$NLS.getISO8859_1Encoded(RWT.java:99)
at org.eclipse.ui.internal.activities.ws.ActivityMessages.get(ActivityMessages.java:68)
at org.eclipse.ui.internal.activities.ws.WorkbenchActivitySupport$2.run(WorkbenchActivitySupport.java:118)
at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:421)
at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:358)
at org.eclipse.jface.dialogs.ProgressMonitorDialog.run(ProgressMonitorDialog.java:517)
at org.eclipse.ui.internal.activities.ws.WorkbenchActivitySupport$4.run(WorkbenchActivitySupport.java:252)
at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:66)
at org.eclipse.ui.internal.activities.ws.WorkbenchActivitySupport$3.run(WorkbenchActivitySupport.java:241)
at org.eclipse.rwt.internal.lifecycle.UICallBackManager$RunnableBase.run(UICallBackManager.java:50)
at org.eclipse.rwt.internal.lifecycle.UICallBackManager.processNextRunnableInUIThread(UICallBackManager.java:165)
at org.eclipse.rwt.internal.lifecycle.RWTLifeCycle.readAndDispatch(RWTLifeCycle.java:245)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:685)
at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2388)
at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2347)
at org.eclipse.ui.internal.Workbench.access$5(Workbench.java:2200)
at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:425)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:288)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:408)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:157)
at org.tcat.citd.sim.emes.rap.application.Application.createUI(Application.java:61)
at org.eclipse.rwt.internal.lifecycle.EntryPointManager.createUI(EntryPointManager.java:92)
at org.eclipse.rwt.internal.lifecycle.RWTLifeCycle.createUI(RWTLifeCycle.java:228)
at org.eclipse.rwt.internal.lifecycle.RWTLifeCycle$UIThreadController.run(RWTLifeCycle.java:116)
at java.lang.Thread.run(Thread.java:619)




More information:
Comment 1 Rüdiger Herrmann CLA 2008-12-17 11:00:12 EST
Thanks for the patch. Applied to CVS HEAD