Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 258881 - Switching to new FilteredTree look causes issues on Mac
Summary: Switching to new FilteredTree look causes issues on Mac
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 258236 259485
Blocks:
  Show dependency tree
 
Reported: 2008-12-15 18:30 EST by Chris Aniszczyk CLA
Modified: 2008-12-23 10:09 EST (History)
2 users (show)

See Also:

Attachments
white background! (33.38 KB, image/png)
2008-12-15 18:30 EST, Chris Aniszczyk CLA 		no flags Details
patch (2.74 KB, patch)
2008-12-22 06:58 EST, Jacek Pospychala CLA 		no flags Details | Diff
patch (1.19 KB, patch)
2008-12-22 07:05 EST, Jacek Pospychala CLA 		no flags Details | Diff
patch (1.20 KB, patch)
2008-12-23 06:39 EST, Jacek Pospychala CLA 		caniszczyk: iplog+
Details | Diff
mylyn/context/zip (657 bytes, application/octet-stream)
2008-12-23 10:09 EST, Chris Aniszczyk CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2008-12-15 18:30:00 EST 
+++ This bug was initially created as a clone of Bug #258236 +++

Switching to the new look causes a white background for the filtered text control.

This happens on Eclipse application launch configurations. What is strange is that this doesn't happen to OSGi launch configurations which reuse the same filtered control.
Comment 1 Chris Aniszczyk CLA 2008-12-15 18:30:22 EST 
Jacek, can you investigate?
Comment 2 Chris Aniszczyk CLA 2008-12-15 18:30:46 EST 
Created attachment 120533 [details]
white background!
Comment 3 Jacek Pospychala CLA 2008-12-19 11:06:54 EST 
No idea about this one. Hopefully I'll put my hands on my friend's Mac on Monday , and we'll see further :-)
Comment 4 Jacek Pospychala CLA 2008-12-22 06:58:44 EST 
Created attachment 121056 [details]
patch

In filteredTree subclass I was assuming, new look is always used, however it's not the case for Mac.

fix is hackish, I'm creating a bug on FilteredTree to allow subclasses check whether new look is used or not.
Comment 5 Jacek Pospychala CLA 2008-12-22 07:05:41 EST 
Created attachment 121057 [details]
patch

sorry, wrong patch.
Comment 6 Jacek Pospychala CLA 2008-12-22 07:08:10 EST 
created bug 259485
Comment 7 Dani Megert CLA 2008-12-23 03:28:28 EST 
>In filteredTree subclass I was assuming, new look is always used, however it's
>not the case for Mac.
Well, yes and no. It should use the native widget/look in both variants but there should not be a need for clients to know that (unless they start changing FilteredTree in a subclass).
Comment 8 Jacek Pospychala CLA 2008-12-23 06:39:59 EST 
Created attachment 121122 [details]
patch

improved, following Dani comment in bug 259485
Comment 9 Chris Aniszczyk CLA 2008-12-23 10:09:34 EST 
done.

> 20081223

Thanks Jacek!
Comment 10 Chris Aniszczyk CLA 2008-12-23 10:09:38 EST 
Created attachment 121143 [details]
mylyn/context/zip