This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 258707 - [editor] add a line between current and recent comments
Summary: [editor] add a line between current and recent comments
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 trivial with 1 vote (vote)
Target Milestone: 3.3   Edit
Assignee: Robert Elves CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 267416 280743 (view as bug list)
Depends on:
Blocks: 290616
  Show dependency tree
 
Reported: 2008-12-12 17:10 EST by Robert Elves CLA
Modified: 2009-10-09 17:36 EDT (History)
3 users (show)

See Also:

Attachments
screenshot showing desired line placement (13.99 KB, image/png)
2009-03-06 14:49 EST, David Green CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Elves CLA 2008-12-12 17:10:27 EST 
When browsing tasks quickly, the comment folding in Older and Recent really helps with tasks with many comments. But I've found that when attempting to reveal then next most recent comments, I more often than not am clicking on the "Older" link only to then realize I intended to click "Recent".  Are other experiencing this phenomena?  I believe the reason for this is that the most recent comments don't have any visual separation of their own from the next group of comments ('Recent').  A line separating this from the next group may help reduce this miss clicking.
Comment 1 Robert Elves CLA 2009-03-06 14:18:09 EST 
*** Bug 267416 has been marked as a duplicate of this bug. ***
Comment 2 David Green CLA 2009-03-06 14:49:24 EST 
Created attachment 127855 [details]
screenshot showing desired line placement

I find that there are very few indications that 'Recent' is not expanded.... the line would help
Comment 3 Steffen Pingel CLA 2009-03-06 15:33:40 EST 
I'll put this on for 3.2 so we can discuss possible fixes.
Comment 4 Steffen Pingel CLA 2009-06-18 14:12:00 EDT 
*** Bug 280743 has been marked as a duplicate of this bug. ***
Comment 5 Robert Elves CLA 2009-10-05 16:32:27 EDT 
I committed the fix for this (TaskEditorCommentPart .createControl()).  The color of the separator line doesn't match the color used on the sections border though.  Does somebody know the trick to this?
Comment 6 Robert Elves CLA 2009-10-05 16:49:17 EDT 
I'll get rid of the extra line showing up...
Comment 7 Steffen Pingel CLA 2009-10-06 00:32:13 EDT 
I have tweaked the color and alignment of the separator. Can you check that this works on Mac and Windows?
Comment 8 Shawn Minto CLA 2009-10-06 12:10:35 EDT 
Looks good on windoes to me
Comment 9 Steffen Pingel CLA 2009-10-07 02:17:46 EDT 
The line should not be displayed if there is not grouping (i.e. if a task has less than 12 comments).
Comment 10 Robert Elves CLA 2009-10-07 13:21:11 EDT 
(In reply to comment #7)
> I have tweaked the color and alignment of the separator. Can you check that
> this works on Mac and Windows?
Mac it still appears darker.

(In reply to comment #9)
> The line should not be displayed if there is not grouping (i.e. if a task has
> less than 12 comments).
Done.
Comment 11 Steffen Pingel CLA 2009-10-09 17:36:42 EDT 
The color has been fixed on Mac.