Community
Participate
Working Groups
Created attachment 120310 [details] view of missing icons The icons in the project explorer for the Dynamic Web project, deployment descriptor are missing. Refer to the image for more details.
I can confirm this behavior on my installation too.
I looked at this a little, to see if possibly related to my removal of org.eclipse.jem.ui (bug 257980). Doesn't seem to be, that is, the icons didn't live there, or anything. Just thought I'd note it here, in case there's some obscure connection.
It should not be about that icons are missing. There is something wrong with the content provider and/or the label provider. In the screenshot it can be seen that the DD tree nests into itself recursively.
Created attachment 120449 [details] fix here is a fix. The problem was that the nodes in the tree were made IAdaptable and in the Content Providers the Root node was taken in really wrong way. I have fixed the root node resolve and the label provider fixed itself.
committed and released.
icons still missing, though node nesting has disappeared. The interesting part is with build from last weeks on my laptop, but it should not. Since I have found that the declarations in the plugin.xml are old and not correct.
Created attachment 120926 [details] labels fixed.
Was this fixed in M4? Or should target be changed to M5?
This is still a problem on the latest smoke driver for 3.1
it was a wrong declaration in plugin xml, funny enough this should not work for more then 3 months. I guess that another bug was not considering the possible children correctly and was fixed recently. However it is fixed and released in 3.1
*** Bug 260583 has been marked as a duplicate of this bug. ***
"No label provider" is still displayed instead of the subnodes for Servlets and Servlet Mappings
Created attachment 122701 [details] screenshot
Created attachment 123873 [details] servlet and servlet mappting. hopefully last one.
commited and released.
I am reopening this bug and changing the version number to 3.0.4, as the same problem is now showing in this weeks smoke test.
Created attachment 124411 [details] 304 patch
Chuck can you review the patch.
The content and label providers are not functioning well since the declarations of possible children are wrong. The values from earlier refactoring are not updated. This was unnoticed most probably, because of a other bug that allowed not defined possible children to exist in the tree. The outcome is incomplete DD tree and missing icons. There is no workaround for this issue. The fix was manually tested. The fix is being reviewed by Chuck. the risk is low since the corrections are only in possible children clause in plugin xml.
Dimitar, is this only for 3.0.4, or does it also applies to 3.1?
looks good - tested fine... approved
Angel, this patch is already in 3.1, so this is only for 3.0.4 This wrong declarations are in for some time now, but they were working. With the new platform however "No label provider" is shown.
Dimitar has somehow managed to mess the flags... Chuck has approved review and David has approved by PMC.
committed and released in R3_0_maintenance
checked in latest 3.0.4
