This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 258358 - fix i18n nits
Summary: fix i18n nits
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.2   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-10 15:56 EST by Steffen Pingel CLA
Modified: 2009-06-20 16:38 EDT (History)
4 users (show)

See Also:


Attachments
bugzilla.ui_BugzillaSearchPage.patch (6.58 KB, patch)
2008-12-19 10:09 EST, Hiroyuki CLA
no flags Details | Diff
No local task context exists. Retrieve from repository? (97.98 KB, image/png)
2009-01-07 19:41 EST, Denis Sakharov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2008-12-10 15:56:14 EST
The code base has recently been internationalized. Please comment on this bug if strings are missing or garbled in the latest weekly build.
Comment 1 Hiroyuki CLA 2008-12-11 08:55:14 EST
I found an error to the resource.  It reported. 

Two "The" is described in 
org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/editors/messages.properties
Line 162

... =Select the capabilities of the the task editor

--- 
I will operate the binary on the weekend. 
And, it reports on the result.
Comment 2 Hiroyuki CLA 2008-12-11 10:14:21 EST
One.  another

Is "tomorrow" ?

org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/messages.properties
Line 62

TasksReminderDialog_Remind_tommorrow=Remind tommorrow
Comment 3 Steffen Pingel CLA 2008-12-11 17:53:34 EST
Thanks. Fixed errors as per comment 1 and 2.
Comment 4 Hiroyuki CLA 2008-12-15 07:32:08 EST
It is divided into the property of one sentence.

When this Working Set is selected views will be filtered just to show only\n
these elements if the Window Working Set is enabled in the view (default).

In org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/workingsets/messages.properties
Line 8 : TaskWorkingSetPage_When_this_Working_Set_is_selected_views_will_be_filtered_just_to_show_only
Line 1 : TaskWorkingSetPage_these_elements_is_enabled_in_the_view

These are used in org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/workingsets/TaskWorkingSetPage.java

	public TaskWorkingSetPage() {
		super("taskWorkingSetPage", Messages.TaskWorkingSetPage_Select_Working_Set_Elements, null); //$NON-NLS-1$
		setDescription("" + Messages.TaskWorkingSetPage_When_this_Working_Set_is_selected_views_will_be_filtered_just_to_show_only //$NON-NLS-1$
				+ Messages.TaskWorkingSetPage_these_elements_is_enabled_in_the_view);
		setImageDescriptor(TasksUiImages.BANNER_WORKING_SET);
	}

The property divided like this causes the mistake. 

Because each property will translate the translator who cooperates in Babel. 
And, the translation of each property is mistranslated. 

It is necessary to define one sentences as one property. 

Comment 5 Steffen Pingel CLA 2008-12-16 14:26:10 EST
Thanks. Addressed comment 5.
Comment 6 Hiroyuki CLA 2008-12-19 10:09:47 EST
Created attachment 120950 [details]
bugzilla.ui_BugzillaSearchPage.patch

Externalize the string used only for the display with Bugzilla Search page
Comment 7 Hiroyuki CLA 2008-12-20 03:46:39 EST
Relating bug 259434 was issued. 
Comment 8 Steffen Pingel CLA 2009-01-03 09:33:55 EST
Patch from comment 6 applied. Thanks Hiroyuki!
Comment 9 Hiroyuki CLA 2009-01-05 07:17:18 EST
Was the matter of Bug 253125 #13  examined?
> Steffen, 2008/12/08
> I am not sure about the externalization of the date format in the tasks.core patch.
> Ideally there would be a single format specified somewhere that would be used by 
> the task editor as well as the task list. I?ll bring this up within the Mylyn team.

Original code;
repositoryQuery.setLastSynchronizedStamp(
new SimpleDateFormat("MMM d, H:mm:ss").format(new Date()));

I propose to unify the date format to another. 
It is to use DateFormat.LONG + DateFormat.SHORT. 
When DueDate is converted into the string, 
DateFormat.LONG + DateFormat.SHORT is used in TaskListToolTip. 

Comment 10 Denis Sakharov CLA 2009-01-06 18:00:19 EST
Hi everyone!
I'm joining this discussion as per Steffen advise.
Comment 11 Denis Sakharov CLA 2009-01-07 19:41:19 EST
Created attachment 121898 [details]
No local task context exists. Retrieve from repository?
Comment 12 Denis Sakharov CLA 2009-01-07 20:22:50 EST
Trying to translate correctly this:
No local task context exists. Retrieve from repository?

First, I had to find out when that message appears. 
I suppose it pops up when I activate a task and a corresponding Bugzilla issue has a task context attached to it but there is no local context yet for that task on my machine (that's why it offers me to retrieve it from repo). Am I correct?
Then, after examining the context .xml file I found out that most of the resources described were referring to OriginId="org.eclipse.mylar.... , which is not names of the mylyn packages anymore. That's probably why I failed to get the correct context for this activated task and consequently got a message in Package Explorer "Empty task context, unfocus or Alt+click". Am I following the logic of the process?

I always try to give meaningful translations based on what's going on during a user interaction and not just a word-to-word stuff.
So, should it be translated as
a) "It appears that you're activating this task for the first time but there is no task context build for it yet. Retrieve task context from repository?" - meaning that one should always get a task context description when activating a task for the first time.

Comment 13 Steffen Pingel CLA 2009-01-08 19:55:50 EST
(In reply to comment #12)
> I suppose it pops up when I activate a task and a corresponding Bugzilla issue
> has a task context attached to it but there is no local context yet for that
> task on my machine (that's why it offers me to retrieve it from repo). Am I
> correct?

Yes, that is correct.

> Then, after examining the context .xml file I found out that most of the
> resources described were referring to OriginId="org.eclipse.mylar.... , which is
> not names of the mylyn packages anymore. That's probably why I failed to get the
> correct context for this activated task and consequently got a message in
> Package Explorer "Empty task context, unfocus or Alt+click". Am I following the
> logic of the process?

Yes, if packages/files are renamed these will be missing in the package explorer.

> I always try to give meaningful translations based on what's going on during a
> user interaction and not just a word-to-word stuff.
> So, should it be translated as
> a) "It appears that you're activating this task for the first time but there is
> no task context build for it yet. Retrieve task context from repository?" -
> meaning that one should always get a task context description when activating a
> task for the first time.

Translations should follow the original (English) text as close as possible. This will ensure that the text is still valid when the implementation changes or the message is used in multiple contexts. It will also help users to match messages when the original text is referenced, e.g. in the user guide.

I do agree that the English text is not very descriptive in this case and could be improved. I'll bring this up on the next Mylyn call. 

Please comment here if you find other places in Mylyn where you feel that strings should be changed.
Comment 14 Denis Sakharov CLA 2009-01-09 00:57:41 EST
Got it, Steffen.
I certainly do the closest translation possible where it applies, though
there are problems with the close translations that should be accounted for:
1. there are no good terminology yet in Russian or it is not well determined (established), unstable. For instance, "Task-Focused UI";
2. the end-users of the product - in our case they are Russian developers, so I try to follow the terminology that's known to them already from the translations made for other software products;
3. I do not see any sense in translating some things like "Mylyn Bugzilla Connector Core" which is a Bundle-Name in org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.core/plugin.properties - it's kindda internal stuff anyway and if I translate it into Russian it would sound really ugly (same goes for "Task-Focused UI"), so I mark those as Non-Translatable;
4. Mylyn's got some stuff that is a bit external to its nature, namely, connectors - Bugzilla, Trac, JIRA - so I try to follow the translations already made for those (too bad not all of them have got internationalized);
5. I should also take into account the terminology that other translator of Eclipse products did (thanks to Babel), which is not good at times but should be coherent to some degree.

Another major thing that is really annoying and takes a lot to do a good job is that for some strings it's difficult to infer in what context it is used, for instance "Mylyn Interest Manipulation" or "Activity Monitor Job" - is it a tooltip or a title of dialog box or a menu item or a button label or just some string that the end-user will never see in UI? 
Taken "Must specify defaultFont", is defaultFont a property and thus should be translated as "You must specify a value for 'defaultFont' property" or "You must specify a correct value for 'defaultFont' property" or "You must specify a correct value for 'defaultFont' attribute" or just "You must specify a default font"?

For some of them I try to get the meaning from the key name, i.e. "FocusPackageExplorerAction.label=Focus on Active Task" is definite for me but "AbstractJavaRelationProvider_Mylyn_degree_of_separation=Mylyn degree of separation:" - how the heck do I translate that "Mylyn degree of separation:" - where is it and what does it mean, I honestly tried to find a notion of "degree of separation" in Mik's manual for Mylyn but :(

BUT, Mik's concept of Task-Focused UI and the way you guys extended that in Tasktop is revolutionary and will become well adopted for lots of domains I'm sure, that's why I'm going on :)
Comment 15 Denis Sakharov CLA 2009-01-09 14:39:52 EST
One other thing that should be fulfilled for the "official or certified" translations, according to common sense, is that:
the newcomers to Mylyn, Tasktop or broader Task-Focused concept always start by the book - some official set of articles or a manual or whatever's available for that matter. Naturally, the terminology for a particular language used in both a manual and the Mylyn UI should be corresponding, even equal.

For the Russian translation I primarily refer to Mik's series of articles at IBM (http://www.ibm.com/developerworks/java/library/j-mylyn1/ , http://www.ibm.com/developerworks/java/library/j-mylyn2/) and their Russian translations (http://www.ibm.com/developerworks/ru/library/j-mylyn1/ , http://www.ibm.com/developerworks/ru/library/j-mylyn2/) which are very well done.

So, if you're going to bring up the internationalization issue on the Mylyn call it should be definitely pointed out that a good current translation of a manual has to precede the translation of UI.
Comment 16 Steffen Pingel CLA 2009-04-08 19:30:59 EDT
The string pointed out in comment #12 is now be improved in cvs head.

(In reply to comment #14)
> 3. I do not see any sense in translating some things like "Mylyn Bugzilla
> Connector Core" which is a Bundle-Name in
> org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.core/plugin.properties - it's
> kindda internal stuff anyway and if I translate it into Russian it would sound
> really ugly (same goes for "Task-Focused UI"), so I mark those as
> Non-Translatable;

That makes sense to me.

> Another major thing that is really annoying and takes a lot to do a good job is
> that for some strings it's difficult to infer in what context it is used, for
> instance "Mylyn Interest Manipulation" or "Activity Monitor Job" - is it a
> tooltip or a title of dialog box or a menu item or a button label or just some
> string that the end-user will never see in UI?

Most of the time the string will refer to a tooltip and label. All Mylyn strings translatable in Babel show up in the UI.

I agree with your point that it's sometimes difficult to infer the context. We'll improve the keys over time to make that more explicit by adding suffixes such as _Title, _Label or _Tooltip.

> Taken "Must specify defaultFont", is defaultFont a property and thus should be
> translated as "You must specify a value for 'defaultFont' property" or "You must
> specify a correct value for 'defaultFont' property" or "You must specify a
> correct value for 'defaultFont' attribute" or just "You must specify a default
> font"?

Those are error messages that will only be presented in case of an unexpected state in WikiText. I am not sure that it makes sense to translate it since it is not very descriptive or helpful.

> 
> For some of them I try to get the meaning from the key name, i.e.
> "FocusPackageExplorerAction.label=Focus on Active Task" is definite for me but
> "AbstractJavaRelationProvider_Mylyn_degree_of_separation=Mylyn degree of
> separation:" - how the heck do I translate that "Mylyn degree of separation:" -
> where is it and what does it mean, I honestly tried to find a notion of "degree
> of separation" in Mik's manual for Mylyn but :(

It's an experimental feature that is only available through the sandbox. You may have to refer to Mik's thesis to get additional background information :).
Comment 17 Steffen Pingel CLA 2009-06-20 16:38:31 EDT
The nits have been resolved for 3.2.