Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 258207 - [ui] Revert dialog let's you click Finish twice
Summary: [ui] Revert dialog let's you click Finish twice
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-09 18:57 EST by Susan McCourt CLA
Modified: 2009-01-07 19:08 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2008-12-09 18:57:24 EST
+++ This bug was initially created as a clone of Bug #257775 +++
<snip> - most of the bug relates to problems on the core side.  Opening this bug to track the UI problem:

>I don't know if it is a factor, but when I reverted, I clicked Finish and was >prompted to continue. The wizard stayed up and I hit Finish again and was again >prompted.

Revert used to gray the wizard until the restart, it seems something here has changed such that it grays briefly and then the wizard becomes active.  It should either close or remain gray.
Comment 1 Susan McCourt CLA 2008-12-09 18:58:11 EST
investigate to see if this is a regression, when it occurred, and whether it's simple to do something for M4.
Comment 2 Susan McCourt CLA 2008-12-10 13:25:25 EST
Checked this scenario on 3.4.
It has always been the case that that wizard goes gray while the provisioning plan for the revert is being computed, and the finish button is restored before the actual profile modification is performed.

What seems to be different in 3.4 is that something locks the UI thread while the operation is being performed (this could just be a timing issue with a repo load needing to occur vs. a true difference between 3.4 and now).  So it was hard for me to click the finish button because the entire UI was not responsive.

In the 3.5 stream, the UI is more responsive so it's easier to click the button.  

I don't think this is urgent for 3.5 M4, but it should be fixed.  The wizard should either be closed to allow the user to keep working, or the buttons remain gray during the profile modification.  See also bug 229354, bug 233069, and bug 251400...Note that this workflow may change as part of bug 216031, so I'll sort all this out then.
Comment 3 Susan McCourt CLA 2009-01-07 19:08:12 EST
Fixed in HEAD >20090107.
This no longer happens in the new revert workflow