257977 – [api] It would be useful for IInteractionContext to provide a means for knowing if something is interesting

This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.

Bug 257977 - [api] It would be useful for IInteractionContext to provide a means for knowing if something is interesting

Summary: [api] It would be useful for IInteractionContext to provide a means for knowi...

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P2 enhancement (vote)
Target Milestone:	3.2
Assignee:	David Green
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2008-12-08 15:21 EST by David Green
Modified:	2009-05-08 20:27 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
a patch implementing the new API (3.55 KB, patch) 2008-12-08 15:21 EST, David Green	no flags	Details \| Diff
updated patch (3.72 KB, patch) 2009-05-04 18:59 EDT, David Green	no flags	Details \| Diff
mylyn/context/zip (5.61 KB, application/octet-stream) 2009-05-04 18:59 EDT, David Green	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description David Green

2008-12-08 15:21:02 EST

while it is currently possible to know if something is interesting given an IInteractionContext, the current APIs make the code inefficient.  A new method on IInteractionContext would make the query easy and fast.

Suggested API change on @IInteractionContext@:

bc. 
	/**
	 * indicate if the interaction element identified by the given handle is interesting
	 * 
	 * @param elementHandle
	 *            the {@link IInteractionElement#getHandleIdentifier() handle identifier}
	 * 
	 * @return true if an {@link #getInteresting() interesting} interaction element exists with the given handle
	 */
	public boolean isInteresting(String elementHandle);

Comment 1 David Green

2008-12-08 15:21:50 EST

Created attachment 119834 [details]
a patch implementing the new API

Comment 2 David Green

2009-01-06 14:58:04 EST

Steffen, any chance you could look at this?

Comment 3 Steffen Pingel

2009-01-06 15:29:57 EST

I'll bug Mik about it.

Comment 4 Steffen Pingel

2009-01-21 20:52:10 EST

This will need further discussion, bumping milestone to next release.

Comment 5 David Green

2009-02-03 01:17:46 EST

This patch is relatively trivial.  It would be nice to have it included in 3.1 if possible.

Comment 6 Shawn Minto

2009-05-04 18:43:36 EDT

David, this patch doesn't apply cleanly anymore, could you re-cut it against HEAD?

Comment 7 David Green

2009-05-04 18:59:14 EDT

Created attachment 134342 [details]
updated patch

patch updated against head.

Comment 8 David Green

2009-05-04 18:59:17 EDT

Created attachment 134343 [details]
mylyn/context/zip

Comment 9 Shawn Minto

2009-05-08 19:19:28 EDT

Thanks for redoing the patch.  This change looks good and I have merged it with the changes that were made yesterday to InteractionContext and have added a very basic test to ensure that this works as expected.  I have committed this patch.

Comment 10 Shawn Minto

2009-05-08 19:20:00 EDT

marking as resolved.