Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 257775 - Revert failed miserably
Summary: Revert failed miserably
Status: RESOLVED DUPLICATE of bug 253862
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Simon Kaegi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-05 16:47 EST by Michael Valenta CLA
Modified: 2009-01-15 11:44 EST (History)
2 users (show)

See Also:

Attachments
Configuration log file (452.10 KB, application/octet-stream)
2008-12-05 16:47 EST, Michael Valenta CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2008-12-05 16:47:21 EST 
Created attachment 119673 [details]
Configuration log file

I installed I20081202 on top of eclipse-SDK-I20081125-0840-win32.zip from the Eclipse update site. The install succeeded but bundles in my target were not found causing my workspace to be unusable (Simon says: no spaces in workspace path) (probably a PDE problem). I tried reverting back but now I can't start Eclipse at all. I have a number of plug-ins loaded on top of Eclipse (e.g. EMF, GEF) and some plug-ins were loaded using the links folder.

I don't know if it is a factor, but when I reverted, I clicked Finish and was prompted to continue. The wizard stayed up and I hit Finish again and was again prompted.
Comment 1 Michael Valenta CLA 2008-12-05 16:50:13 EST 
The moral of the story is don't revert, even if Simon says ;-)
Comment 2 Simon Kaegi CLA 2008-12-05 17:03:05 EST 
In retrospect it was a bad idea to revert given the recent path changes. I suspect that this set of changes (pathing) will make rolling back from a 3.5 install to 3.4 tough given that we had to correct 3.4 behavior in several cases. 

A few additional things I noticed in the reverted install:
1) the eclipse.ini had lost the -startup
2) the launcher jar was refereneced using an absolute URI (should be a file path)
3) the bundle.info was written with relative uri instead of the older style file:... bundle locations we should be writing for an older simpleconfigurator.
Comment 3 Pascal Rapicault CLA 2008-12-05 17:24:15 EST 
we need to understand the scope of this while testing m4. For example, can I revert to a previous I build leading to M4?
Comment 4 Pascal Rapicault CLA 2008-12-09 13:19:48 EST 
It seems that some simple revert is possible. Moving to M5.
Comment 5 Simon Kaegi CLA 2008-12-09 13:52:20 EST 
For the problem reverting the bundle info file (3) one thing that is causing problems is that the old version we're matching against is too old. We should bump it to any versions prior to M4 to allow us to for example revert to M3 in the simplest case. This safe since even for the builds leading up to M4 since we can still read old style relative URI in bundle.info.
Comment 6 Simon Kaegi CLA 2009-01-15 11:43:35 EST 
Update on this bug...
Of the 3 problems I listed in comment 2 only the first remains. I'm going to mark this bug as a dup of bug Bug 258879 which is the first problem e.g. "-startup". The other 2 are already fixed in HEAD.


*** This bug has been marked as a duplicate of bug 253862 ***
Comment 7 Simon Kaegi CLA 2009-01-15 11:44:28 EST 
The dup'ed bug is right. Above I meant to reference bug 253862.