Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 257773 - Associated sites are not read if the originating URL is a p2-enabled site
Summary: Associated sites are not read if the originating URL is a p2-enabled site
Status: RESOLVED INVALID
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: p2 (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 234213
Blocks:
  Show dependency tree
 
Reported: 2008-12-05 16:38 EST by Nick Boldt CLA
Modified: 2009-01-19 14:27 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Boldt CLA 2008-12-05 16:38:57 EST
Tasktop subscription update sites work (they have no p2 metadata); the jboss site.xml works (case b - bug 234213 comment 18). The
jboss p2 repo, generated FROM the site.xml (case a - bug 234213 comment 18), DOES NOT. 

In fact, checking in content.xml from
http://download.jboss.org/jbosstools/updates/nightly/trunk/content.jar shows
that the associated sites are NOT included in that file.

To facilitate testing this, I'll add associated sites to the PDT 2.0 update site so that you can use that site instead of the JBoss Tools one. PDT 2.0 depends on Ganymede and DLTK 1.0, so it's a good test case for this scenario.
Comment 1 John Arthorne CLA 2008-12-08 11:05:59 EST
Investigate for M5.
Comment 2 John Arthorne CLA 2008-12-11 14:28:23 EST
> To facilitate testing this, I'll add associated sites to the PDT 2.0 update
> site so that you can use that site instead of the JBoss Tools one.

Have you done this? What is the URL of that site? I looked here but didn't see an associate site URL:

http://download.eclipse.org/tools/pdt/updates/2.0/interim/
Comment 3 Nick Boldt CLA 2008-12-11 19:26:32 EST
Sorry, it's there now. 

When you first add http://download.eclipse.org/tools/pdt/updates/2.0/milestones/, the DLTK 1.0 site will appear; however, if you already have that site listed but it's not enabled, adding the PDT site will not make it appear in the list. Same for Ganymede -- if you happen to have disabled it (Help > Software Updates... > Available Software > Manage Sites... > (uncheck Ganymede site) > OK > Manage Sites... > Add...). Of course this is bug 241307. Any chance that'll be backported to Eclipse 3.4.2?

Note that for the PDT site, I added the associatedSitesURL into site.xml after generating p2 metadata, whereas for the JBoss site, I generate the p2 metadata from site.xml (which already contains the associatedSitesURL). Should that matter? 
Comment 4 John Arthorne CLA 2008-12-12 15:24:54 EST
It sounds to me like this bug is invalid (or a dup of bug 241307). If you create a p2 repository from an classic update site, associate sites are converted into repository references. This seems to be working in your case as the reference is present on the PDT update site. I added a test case to our test suites for this and it is passing.

> Note that for the PDT site, I added the associatedSitesURL into site.xml after
> generating p2 metadata, whereas for the JBoss site, I generate the p2 metadata
> from site.xml (which already contains the associatedSitesURL).

Yes. If you have a p2 repository (content.jar/content.xml), then the site.xml is never referenced. The site.xml exists only for a) compatibility with Eclipse 3.3, or b) as input when generating a p2 repository.
Comment 5 Nick Boldt CLA 2008-12-12 15:44:26 EST
(In reply to comment #4)
> Yes. If you have a p2 repository (content.jar/content.xml), then the site.xml
> is never referenced. The site.xml exists only for a) compatibility with Eclipse
> 3.3, or b) as input when generating a p2 repository.

Ah, but I *do* have content.jat on the PDT site:

http://download.eclipse.org/tools/pdt/updates/2.0/milestones/content.jar

It's also on the JBoss site:

http://download.jboss.org/jbosstools/updates/nightly/trunk/content.jar

And both have site.xmls that ref an associateSites.xml 

http://download.eclipse.org/tools/pdt/updates/2.0/milestones/site.xml
http://download.eclipse.org/tools/pdt/updates/associateSites.xml

http://download.jboss.org/jbosstools/updates/nightly/trunk/site.xml
http://download.jboss.org/jbosstools/updates/nightly/trunk/associateSites.xml

So, then... it seems the only issue is that for PDT the DLTK site is added; for JBT, the BIRT site is not. I'll keep playing with it -- problem might be w/ my XML, rather than with p2.
Comment 6 John Arthorne CLA 2009-01-19 14:27:45 EST
Closing. I was not able to reproduce a problem.