Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 257503 - [Net] Switching to Native proxy provider doesn't clear system properties
Summary: [Net] Switching to Native proxy provider doesn't clear system properties
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-04 06:49 EST by Pawel Pogorzelski CLA
Modified: 2009-06-02 07:02 EDT (History)
1 user (show)

See Also:

Attachments
Patch_v01 (6.88 KB, patch)
2009-01-20 11:01 EST, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_v02 (10.20 KB, patch)
2009-01-21 05:07 EST, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_v03 (11.33 KB, patch)
2009-01-21 06:47 EST, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pogorzelski CLA 2008-12-04 06:49:19 EST 
Build id: I20081125-0840

Steps To Reproduce:
1. Go to Window > Preferences > General > Network connection
2. Select "Eclipse" as the active provider
3. Specify settings for all available protocols and click "OK"
4. Go to Network connection select "Native" provider and click "OK"

Expected:
System properties exported by ProxyManager match proxy setting from OS

Actual:
System properties exported by ProxyManager match proxy setting from Eclipse
Comment 1 Pawel Pogorzelski CLA 2009-01-20 11:01:09 EST 
Created attachment 123090 [details]
Patch_v01

There was a problem in code that handles flushing information about active proxies to system properties. This operation is triggered from a few places but properties always corresponded to setting obtained from Eclipse proxy provider. The same is true about proxy bypass list.

I make the smallest change possible to address the issue. That is I changed methods that update system properties to fetch from ProxySelector settings that correspond to active provider.

Szymon, please review it.
Comment 2 Pawel Pogorzelski CLA 2009-01-21 05:07:20 EST 
Created attachment 123191 [details]
Patch_v02

I added a unit test.
Comment 3 Pawel Pogorzelski CLA 2009-01-21 06:47:55 EST 
Created attachment 123212 [details]
Patch_v03

Updated copyrights and some minor changes.

Tomasz, will you have a look?
Comment 4 Tomasz Zarna CLA 2009-01-21 12:20:32 EST 
Patch_v03 released to HEAD.