Community
Participate
Working Groups
Build ID: I20080617-2000 Steps To Reproduce: 1. Mirror a repository (try with a not too big one like http://m2eclipse.sonatype.org/update/) 2. Add it to your Eclipse installation 3. It will display something like 'file:x:/local/path/to/mirror - metadata' More information: At the moment, the command line looks like this : eclipsec -verbose -application org.eclipse.equinox.p2.metadata.repository.mirrorApplication -source http://www.someurl.com/ -destination file:x:/local/path/to/mirror It would be great to support an additional option like -name 'MyCompany - Local (Merged) Mirror'. That would let us have more understandable repository names in the UI. Thanks a lot. Cheers.
Which version of the mirror application are you using? I'm looking at my code and if a repository already exists at the destination it doesn't modify the name. If the mirror application needs to create a repository it uses the source repository's name. I remember making this change quite a while ago as well. However, I can still see a case where simply copying the source repository's name can lead to confusion.
Hi Andrew, as stated in the bug report, I'm using 3.4. Btw, am I wrong saying eclipse.exe (or eclipsec.exe) doesn't have any -version option?
Ah! I'm sorry I notice that you do state which build you are using. Like I said, this problem has already been fixed to a degree. I agree that being able to specify a name for the destination might be useful but I'd be concerned about the expected behaviour. Specifically what happens if a repository exists at the destination but a repository name is specified? We could use the existing name, overwrite the existing name, or only overwrite the existing name if the argument to remove the destination's existing content is included. I'm unsure about the answer to your question but I can pass it on to someone who would be.
I think there was a request for a -version command-line option at one point but I can't find it in bugzilla right now. I believe there was a question of what it would return... the version of the primary feature? the product version? And then once you install a few extra features then you're all over the place. John, do you have an opinion on this (or remember the previous discussion)?
> John, do you have an opinion on this (or remember the previous discussion)? I think having an argument to specify the destination repository name makes sense. I think it should just overwrite the existing name if a repository already exists. I vaguely remember the -version argument discussion. I don't think it has much value. Each feature, product, and bundle has a potentially different version, and the launcher itself has its own version.
Implemented and tested. Waiting for overlapping changes for Bug 255685 to be released before I can make the patch. Currently I use the argument "-name <repository name>" to get the destination name. Any suggestions for a better argument? "-destinationName" perhaps?
-destinationName would be more descriptive.
Or -repositoryName or even (but a bit long) -destinationRepositoryName, or shorted -destinationRepoName... Sorry about that :-). Cheers.
(In reply to comment #8) > Or -repositoryName or even (but a bit long) -destinationRepositoryName, or > shorted -destinationRepoName... Sorry about that :-). > Cheers. > -repositoryName I think is a bit vague (which repository). The other 3 are a bit long. That said, do we think -destinationName is descriptive enough to let the user know we're renaming the destination? Of course I think this problem is also shared by -destinationRepositoryName and -destinationRepoName. But arguments like -desiredDestinationName are a bit awkward... -nameDestintion perhaps? In this case I think most users will read "name" as a verb and know we are "naming the destination" to whatever they set.
I think you're over-analyzing this. -destinationName is fine. If a user isn't sure what this does they can read the doc.
Created attachment 119784 [details] Allso users to set destination repository name Includes test cases. Uses the argument "-destinationName"
Released to HEAD.
