Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 256879 - [package explorer] Assign Working Sets dialog should preserve check box setting
Summary: [package explorer] Assign Working Sets dialog should preserve check box setting
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Raksha Vasisht CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-28 07:08 EST by Dani Megert CLA
Modified: 2009-01-27 05:29 EST (History)
0 users

See Also:

Attachments
The check box setting for Assign Working Sets dialog preserves the state entered by the user before OK is pressed (and not if cancel is pressed) . (3.27 KB, patch)
2008-12-08 10:06 EST, Raksha Vasisht CLA 		daniel_megert: review-
Details | Diff
Made the tweaks required. [The check box setting for Assign Working Sets dialog preserves the state entered by the user before OK is pressed (and not if cancel is pressed) ]. (2.98 KB, patch)
2008-12-09 01:13 EST, Raksha Vasisht CLA 		daniel_megert: iplog+
daniel_megert: review+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-11-28 07:08:36 EST 
N20081126-2000.

The dialog to assign working sets has a check box (show only package explorer working sets). This setting is not preserved but it should be.
Comment 1 Raksha Vasisht CLA 2008-12-08 10:06:34 EST 
Created attachment 119794 [details]
The check box setting for Assign Working Sets dialog preserves the state entered by the user before OK is pressed (and not if cancel is pressed) .
Comment 2 Dani Megert CLA 2008-12-08 10:46:31 EST 
Thanks for the patch Raksha. It works but is too complicated: instead of extending the button creation you'd better subclass buttonPressed(int).

Some trivial things to fix:
- indentation after "if (fSettings.get(SETTINGS_SHOW_VISIBLE_ONLY) == null)"
- CLASS_WORKING_SET_MODEL_AWARE_SELECTION_DIALOG ==> DIALOG_SETTINGS_SECTION
Comment 3 Raksha Vasisht CLA 2008-12-09 01:13:53 EST 
Created attachment 119864 [details]
Made the tweaks required. [The check box setting for Assign Working Sets dialog preserves the state entered by the user before OK is pressed (and not if cancel is pressed) ].
Comment 4 Dani Megert CLA 2008-12-15 05:23:00 EST 
Committed with minor corrections:
- call super.buttonPressed(buttonId) instead of copying logic
- added comment to buttonPressed
- added '.' to first Javadoc sentence
Comment 5 Dani Megert CLA 2009-01-27 05:29:30 EST 
Verified in I20090127-0100.