Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 256580 - org.eclipse.ecf.core.ContainerFactory.getContainer(ID) never returns and causes caller to hang indefinitely
Summary: org.eclipse.ecf.core.ContainerFactory.getContainer(ID) never returns and caus...
Status: CLOSED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.core (show other bugs)
Version: 2.1.0   Edit
Hardware: All All
: P3 blocker (vote)
Target Milestone: ---   Edit
Assignee: Scott Lewis CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 256603
  Show dependency tree
 
Reported: 2008-11-26 04:37 EST by Markus Kuppe CLA
Modified: 2008-11-26 11:35 EST (History)
0 users

See Also:
slewis: review+

Attachments
a patch (897 bytes, patch)
2008-11-26 04:57 EST, Markus Kuppe CLA 		no flags Details | Diff
mylyn/context/zip (988 bytes, application/octet-stream)
2008-11-26 04:58 EST, Markus Kuppe CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Kuppe CLA 2008-11-26 04:37:59 EST 
org.eclipse.ecf.core.ContainerFactory.getContainer(ID) never reaches the break condition
Comment 1 Markus Kuppe CLA 2008-11-26 04:55:28 EST 
Bumping to blocker
Comment 2 Markus Kuppe CLA 2008-11-26 04:57:59 EST 
Created attachment 118760 [details]
a patch
Comment 3 Markus Kuppe CLA 2008-11-26 04:58:02 EST 
Created attachment 118761 [details]
mylyn/context/zip
Comment 4 Markus Kuppe CLA 2008-11-26 04:58:44 EST 
Assigning to Scott, please review.
Comment 5 Scott Lewis CLA 2008-11-26 09:55:30 EST 
The patch looks fine so please go ahead and commit.  How embarrassing :).  That's what open source is about though :).
Comment 6 Markus Kuppe CLA 2008-11-26 10:38:19 EST 
Fixed in HEAD
Comment 7 Markus Kuppe CLA 2008-11-26 10:40:49 EST 
Fixed in Revision_2_1, please verify
Comment 8 Scott Lewis CLA 2008-11-26 10:43:19 EST 
(In reply to comment #7)
> Fixed in Revision_2_1, please verify
> 

Verified that it's fixed in both HEAD and Release_2_1 streams.

Thanks.
Comment 9 Scott Lewis CLA 2008-11-26 10:45:10 EST 
(In reply to comment #8)
> (In reply to comment #7)
> > Fixed in Revision_2_1, please verify
> > 
> 
> Verified that it's fixed in both HEAD and Release_2_1 streams.
> 
> Thanks.
> 

Actually, I think you should also commit this fix to Release_2_0 stream for our 2.0.2 maintenance release.
Comment 10 Markus Kuppe CLA 2008-11-26 10:59:13 EST 
Done for Revision_2_0, please verify
Comment 11 Scott Lewis CLA 2008-11-26 11:35:10 EST 
(In reply to comment #10)
> Done for Revision_2_0, please verify
> 

Verified fixed in Release_2_0 stream.  Closing.  Thanks.