Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 256561 - [WorkingSets] Possibly broken code in ModifyWorkingSetDelegate.getItems()
Summary: [WorkingSets] Possibly broken code in ModifyWorkingSetDelegate.getItems()
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Hitesh CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 260747 261069 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-11-26 04:01 EST by Dani Megert CLA
Modified: 2009-06-01 14:26 EDT (History)
5 users (show)

See Also:

Attachments
Patch 1 (1010 bytes, patch)
2008-12-09 07:34 EST, Hitesh CLA 		emoffatt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-11-26 04:01:09 EST 
I20081125-0840

While doing the dead-code analysis I found this code in
org.eclipse.ui.internal.actions.ModifyWorkingSetDelegate.getItems():

	for (int k = 0; k < adaptables.length; k++) {
		if (existingElements.contains(adaptables[k]))
			visible = true; // show if any element
							// is present in removal
		break;
	}

Looks like the braces got missing.
Comment 1 Kim Horne CLA 2008-11-26 09:48:05 EST 
Hitesh, could you take a look at this and make sure there's nothing else bone-headed going on here?
Comment 2 Hitesh CLA 2008-12-09 07:34:42 EST 
Created attachment 119897 [details]
Patch 1

Going by the code comment there and looking at the class, the braces need to be added to that if statement. Other than that, the class looks fine to me.
Comment 3 Paul Webster CLA 2009-01-13 08:35:05 EST 
*** Bug 260747 has been marked as a duplicate of this bug. ***
Comment 4 Olivier Thomann CLA 2009-01-13 08:46:27 EST 
Will this be released anytime soon ?
The sooner, the better.
Comment 5 Prakash Rangaraj CLA 2009-01-15 04:07:44 EST 
*** Bug 261069 has been marked as a duplicate of this bug. ***
Comment 6 Eric Moffatt CLA 2009-01-15 12:58:51 EST 
Done. Committed in >20090115. Applied the patch...
Comment 7 Olivier Thomann CLA 2009-01-15 13:01:18 EST 
Target milestone is not set. Done now.
Comment 8 Hitesh CLA 2009-01-27 05:51:49 EST 
Verified in I20090126-1800.