Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 256556 - [Progress] Possibly broken code in DetailedProgressViewer.setFocus
Summary: [Progress] Possibly broken code in DetailedProgressViewer.setFocus
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Prakash Rangaraj CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-26 03:45 EST by Dani Megert CLA
Modified: 2009-06-03 13:45 EDT (History)
2 users (show)

See Also:

Attachments
Patch v01 (1.03 KB, patch)
2008-11-26 03:58 EST, Prakash Rangaraj CLA 		pwebster: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-11-26 03:45:59 EST 
I20081125-0840

While doing the dead-code analysis I found this code in org.eclipse.ui.internal.progress.DetailedProgressViewer.setFocus():

	for (int i = 0; i < children.length; i++) {
		ProgressInfoItem item = (ProgressInfoItem) children[i];
		item.setButtonFocus();
		return;
	}

Obviously the loop is useless as it will at most set the focus on children[0].
Comment 1 Prakash Rangaraj CLA 2008-11-26 03:58:55 EST 
Created attachment 118752 [details]
Patch v01

Good catch :-)
Comment 2 Paul Webster CLA 2008-12-04 11:35:34 EST 
Released to HEAD >20081204
PW
Comment 3 Paul Webster CLA 2008-12-09 13:30:05 EST 
In I20081209-0100
PW