Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 256516 - [TabbedProperties] TabbedPropertySheetPage to allow some options
Summary: [TabbedProperties] TabbedPropertySheetPage to allow some options
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-25 17:38 EST by Lidija Grahek CLA
Modified: 2009-06-03 13:14 EDT (History)
1 user (show)

See Also:


Attachments
Patch (3.99 KB, patch)
2008-11-25 17:38 EST, Lidija Grahek CLA
bokowski: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lidija Grahek CLA 2008-11-25 17:38:49 EST
Created attachment 118719 [details]
Patch

It would be nice if TabbedPropertySheetPage allowed:
- Indicating if the title should be generated or not
- Retrieving title text and image
- Indicating that partActivationListener should not be generated.
Attached patch contains these additions.
Comment 1 Anthony Hunter CLA 2008-11-26 11:28:46 EST
I talked to Lidija a little more about this request and here is what they are asking for.

They are extending TabbedPropertySheetPage and want to make use of a title bar, but do not want the title bar shown in the TabbedPropertyComposite. To this end, they still will have a labelProvider defined in the propertyContributor extension.

So they need a way to turn off the title bar in the UI as well as an API to get the image and label in the title bar.

They also want to override the partActivationListener. There is no way to do this since the registration is inside TabbedPropertySheetPage.createControl()
Comment 2 Anthony Hunter CLA 2008-11-26 11:29:51 EST
I have committed the patch to HEAD.

I added @since 3.5 tags to the JavaDoc since our API tools require us to do so.
Comment 3 Anthony Hunter CLA 2009-01-09 13:00:44 EST
(In reply to comment #1)
> I talked to Lidija a little more about this request and here is what they are
> asking for.
> 
> They also want to override the partActivationListener. There is no way to do
> this since the registration is inside TabbedPropertySheetPage.createControl()
> 

The group does not need to override the partActivationListener. I am removing this in Bug 259179 .
Comment 4 Boris Bokowski CLA 2009-06-03 13:14:34 EDT
Comment on attachment 118719 [details]
Patch

added missing iplog+ flag