This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 256198 - description change lost when starting progress
Summary: description change lost when starting progress
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows XP
: P2 critical (vote)
Target Milestone: 3.1   Edit
Assignee: Thomas Ehrnhoefer CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 243059 258199 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-11-22 14:21 EST by Bob Swift CLA
Modified: 2009-03-08 00:12 EST (History)
3 users (show)

See Also:

Attachments
TestCase (8.86 KB, patch)
2009-01-22 16:48 EST, Thomas Ehrnhoefer CLA 		no flags Details | Diff
mylyn/context/zip (182.40 KB, application/octet-stream)
2009-01-22 16:49 EST, Thomas Ehrnhoefer CLA 		no flags Details
TestCase and Fix (10.81 KB, patch)
2009-01-22 17:12 EST, Thomas Ehrnhoefer CLA 		no flags Details | Diff
mylyn/context/zip (193.78 KB, application/octet-stream)
2009-01-22 17:12 EST, Thomas Ehrnhoefer CLA 		no flags Details
split-up test and fix (13.09 KB, patch)
2009-01-23 14:02 EST, Thomas Ehrnhoefer CLA 		no flags Details | Diff
mylyn/context/zip (34.81 KB, application/octet-stream)
2009-01-23 14:02 EST, Thomas Ehrnhoefer CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Swift CLA 2008-11-22 14:21:42 EST 
Build ID: I20080617-2000

Steps To Reproduce:
1. Change description field
2. Change to start progress on issue
3. Click to attach context
4. Submit 

More information:
JIRA 3.13
JIRA Connector 3.0.2.v20080918-1100-e3x

Description change lost, start progress is done and context attached correctly.  Issue change log indicates no description change.
Comment 1 Steffen Pingel CLA 2008-12-09 18:51:26 EST 
*** Bug 258199 has been marked as a duplicate of this bug. ***
Comment 2 David Green CLA 2008-12-09 20:29:22 EST 
Perhaps we could raise the priority/severity of this one?  Data loss is a pretty severe problem.
Comment 3 Steffen Pingel CLA 2008-12-09 21:54:13 EST 
Priority changed in accordance with Bugzilla guidelines: https://bugs.eclipse.org/bugs/bug_status.html#bug_severity .
Comment 4 David Green CLA 2009-01-07 12:54:42 EST 
This one hit me again today.  Could we set the target milestone for 3.1?  Also, if I were to look into this one any hints on where to start?  Thanks.
Comment 5 Steffen Pingel CLA 2009-01-07 21:55:48 EST 
We'll take a pass through the JIRA bugs in two weeks and I'll consider prioritizing this bug.
Comment 6 Steffen Pingel CLA 2009-01-15 14:10:58 EST 
As a first pass to avoid data loss it should be possible to show a warning message.
Comment 7 Thomas Ehrnhoefer CLA 2009-01-22 16:48:56 EST 
Created attachment 123435 [details]
TestCase

here is the (now failing) testcase, fix coming up...
Comment 8 Thomas Ehrnhoefer CLA 2009-01-22 16:49:00 EST 
Created attachment 123436 [details]
mylyn/context/zip
Comment 9 Thomas Ehrnhoefer CLA 2009-01-22 17:12:08 EST 
Created attachment 123442 [details]
TestCase and Fix

the all-in-one patch
Comment 10 Thomas Ehrnhoefer CLA 2009-01-22 17:12:12 EST 
Created attachment 123443 [details]
mylyn/context/zip
Comment 11 Steffen Pingel CLA 2009-01-22 23:47:43 EST 
Patch looks good. Just one minor nit: Can you break the test case up? Each of the blocks should be in a separate test method otherwise it gets cumbersome to figure out what went wrong if a call in the middle of the method fails.
Comment 12 Thomas Ehrnhoefer CLA 2009-01-23 14:02:54 EST 
Created attachment 123578 [details]
split-up test and fix
Comment 13 Thomas Ehrnhoefer CLA 2009-01-23 14:02:56 EST 
Created attachment 123579 [details]
mylyn/context/zip
Comment 14 Steffen Pingel CLA 2009-01-24 16:54:57 EST 
Good stuff! A few comments: The expected value should always be the first first argument in JUnit's assert...() methods. To make it easy to determine what is tested we put the name of the method under test first in a JUnit test case, e.g. testPostTaskDataAddComment() and try to use descriptive names even if they get long. 
I have simplified the test cases slightly to not rely on the task data offline store but test everything "in memory". We should probably remove some methods in JiraTestUtil since it is not obvious that these require task data to be stored on disk to return meaningful results.
Comment 15 Thomas Ehrnhoefer CLA 2009-01-26 12:39:45 EST 
Totally makes sense, thank you for changing that for me.
Comment 16 David Green CLA 2009-01-26 13:25:06 EST 
Steffen, Thomas, thanks for fixing this one.
Comment 17 Steffen Pingel CLA 2009-03-08 00:12:38 EST 
*** Bug 243059 has been marked as a duplicate of this bug. ***