Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 256150 - [DataBinding] Databinding of Interfaces
Summary: [DataBinding] Databinding of Interfaces
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.2   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Matthew Hall CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 296011 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-11-21 12:13 EST by Martin Frey CLA
Modified: 2010-03-22 14:34 EDT (History)
3 users (show)

See Also:

Attachments
The current fix i use with an aspect (2.55 KB, text/plain)
2008-11-21 12:15 EST, Martin Frey CLA 		no flags Details
Patchfile (3.75 KB, text/plain)
2008-11-21 12:16 EST, Martin Frey CLA 		bokowski: iplog+
Details
Merged Martin's patch with HEAD (4.09 KB, patch)
2009-01-20 18:37 EST, Matthew Hall CLA 		no flags Details | Diff
mylyn/context/zip (5.08 KB, application/octet-stream)
2009-01-20 18:37 EST, Matthew Hall CLA 		no flags Details
Added unit tests (13.72 KB, patch)
2009-01-20 19:14 EST, Matthew Hall CLA 		no flags Details | Diff
mylyn/context/zip (16.37 KB, application/octet-stream)
2009-01-20 19:14 EST, Matthew Hall CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Frey CLA 2008-11-21 12:13:12 EST 
The current implementation of org.eclipse.core.databinding.beans.BeansObservables works fine if you use the binding on a real Bean.
We used always Interfaces for the binding definition and since interfaces don't have a superclass the Introspector "just" finds the definitions of exactly the given interface, even if it extends another one.

I think the solution lies in the getPropertyDescriptor method of BeansObservables and the enhancement is easy. -> attached patchfile
(I didnt take a look on the performance side yet)

For the moment i use an aspect to fix this issue for the moment. -> attached Aspect.
Comment 1 Martin Frey CLA 2008-11-21 12:15:55 EST 
Created attachment 118499 [details]
The current fix i use with an aspect
Comment 2 Martin Frey CLA 2008-11-21 12:16:47 EST 
Created attachment 118500 [details]
Patchfile
Comment 3 Boris Bokowski CLA 2008-11-24 14:25:16 EST 
Marking for investigation in M5.
Comment 4 Matthew Hall CLA 2008-11-26 11:12:37 EST 
+1
Comment 5 Boris Bokowski CLA 2009-01-20 16:02:51 EST 
Matt, can you have a look and merge this into HEAD if it looks OK? I don't want to get in your way while you move the code from the branch into HEAD.
Comment 6 Matthew Hall CLA 2009-01-20 16:54:46 EST 
Will do--I'm shooting for sometime tonight on both 194734 and this bug.
Comment 7 Matthew Hall CLA 2009-01-20 18:37:51 EST 
Created attachment 123140 [details]
Merged Martin's patch with HEAD
Comment 8 Matthew Hall CLA 2009-01-20 18:37:55 EST 
Created attachment 123141 [details]
mylyn/context/zip
Comment 9 Matthew Hall CLA 2009-01-20 19:14:53 EST 
Created attachment 123150 [details]
Added unit tests
Comment 10 Matthew Hall CLA 2009-01-20 19:14:56 EST 
Created attachment 123151 [details]
mylyn/context/zip
Comment 11 Matthew Hall CLA 2009-01-20 19:16:51 EST 
Released to HEAD > 20090120
Comment 12 Ovidio Mallo CLA 2010-03-22 14:34:54 EDT 
*** Bug 296011 has been marked as a duplicate of this bug. ***