Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 256081 - [Net] Remove unnecessary API from IProxyData
Summary: [Net] Remove unnecessary API from IProxyData
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-21 04:49 EST by Pawel Pogorzelski CLA
Modified: 2009-06-02 06:59 EDT (History)
1 user (show)

See Also:

Attachments
Patch_v01 (17.58 KB, patch)
2008-11-25 04:42 EST, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_v02 (18.30 KB, patch)
2008-11-25 05:49 EST, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pogorzelski CLA 2008-11-21 04:49:31 EST 
Build ID: N20081120-2000

Steps To Reproduce:
The UI for proxy settings consumes ProxyData class from core.net. This is the same class returned to clients of the IProxyService API when they prompt for settings for a given host.

Since set of data needed differs in a case of UI and IProxyService API's clients a new class should be extracted for UI only use.


More information:
Comment 1 Pawel Pogorzelski CLA 2008-11-25 04:27:48 EST 
Changing bug summary from "[Net] Create separate VO for proxy preferences UI" because it suggested the solution of the problem.
Comment 2 Pawel Pogorzelski CLA 2008-11-25 04:42:56 EST 
Created attachment 118643 [details]
Patch_v01
Comment 3 Pawel Pogorzelski CLA 2008-11-25 05:49:13 EST 
Created attachment 118647 [details]
Patch_v02

Szymon found that the change in tests reduced tests coverage.

This patch fixes the issue.
Comment 4 Szymon Brandys CLA 2008-11-25 06:04:02 EST 
Looks good. Thanks Pawel.
Comment 5 Tomasz Zarna CLA 2008-11-25 06:08:26 EST 
Applied to HEAD.