Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 256053 - Launching console using new Eclipse launcher (a la 132)
Summary: Launching console using new Eclipse launcher (a la 132)
Status: RESOLVED FIXED
Alias: None
Product: Equinox
Classification: Eclipse Project
Component: Framework (show other bugs)
Version: 3.5   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Thomas Watson CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-20 22:17 EST by Erin Schnabel CLA
Modified: 2008-12-02 12:37 EST (History)
0 users

See Also:


Attachments
patch for creating console in both EquinoxStarter & Equinox launcher (10.63 KB, patch)
2008-11-20 22:17 EST, Erin Schnabel CLA
no flags Details | Diff
create console in both EquinoxStarter & Equinox launcher (9.34 KB, patch)
2008-11-20 22:29 EST, Erin Schnabel CLA
tjwatson: iplog+
Details | Diff
patch to set socket reuse option when creating console socket (1.39 KB, patch)
2008-11-25 13:18 EST, Erin Schnabel CLA
tjwatson: iplog+
Details | Diff
patch (10.38 KB, patch)
2008-12-01 15:01 EST, Thomas Watson CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Erin Schnabel CLA 2008-11-20 22:17:25 EST
Created attachment 118423 [details]
patch for creating console in both EquinoxStarter & Equinox launcher

Using EclipseStarter, you get the handy built-in console if you specify a console port.

The new org.eclipse.osgi.launch.Equinox launcher doesn't provide this console function.

So, attached is a patch that shares the code to start the equinox console between the EclipseStarter and the new Equinox launcher.  

If the "osgi.console" property is set, a ConsoleManager instance will be created, which is then used to start/stop the console.
Comment 1 Erin Schnabel CLA 2008-11-20 22:29:29 EST
Created attachment 118424 [details]
create console in both EquinoxStarter & Equinox launcher

The original version had .classpath changes I meant to take out.. sorry.
Comment 2 Erin Schnabel CLA 2008-11-25 13:18:50 EST
Created attachment 118678 [details]
patch to set socket reuse option when creating console socket
Comment 3 Thomas Watson CLA 2008-12-01 15:01:58 EST
Created attachment 119200 [details]
patch

I made the following tweaks to the patch.

- removed the ability to define a console class.  This was a silly undocumented configuration option
- removed reflection to call FrameworkConsole constructor and shutdown
- changed the order when the console manager is shutdown in EquinoxLauncher.stop(). The console should be shutdown before stopping the system bundle.
Comment 4 Thomas Watson CLA 2008-12-01 15:03:11 EST
Patch released to HEAD.