Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 255836 - [Net] Wrong method used in org.eclipse.ui.net
Summary: [Net] Wrong method used in org.eclipse.ui.net
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 255814 257109
Blocks:
  Show dependency tree
 
Reported: 2008-11-19 11:40 EST by Olivier Thomann CLA
Modified: 2009-06-02 06:58 EDT (History)
1 user (show)

See Also:

Attachments
Patch_v01 (1.94 KB, patch)
2008-12-12 07:05 EST, Pawel Pogorzelski CLA 		no flags Details | Diff
Patch_v02 (1.27 KB, patch)
2008-12-12 07:25 EST, Pawel Pogorzelski CLA 		pawel.pogorzelski1: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2008-11-19 11:40:38 EST 
That bundle is supposed to be Foundation 1.0 compliant according to the 3.4
plan. Maybe this has changed for 3.5.
The EEs defined for this project are:
Bundle-RequiredExecutionEnvironment: J2SE-1.4,
 CDC-1.0/Foundation-1.0,
 J2SE-1.3

And for the compilation, pde.build ends up taking the first execution
environment which is 1.4. If pde.build would take the execution
environment CDC-1.0/Foundation-1.0 or J2SE-1.3, it would not compile.

The bundle execution environment should be changed to 1.4 or some type
references should be removed.

Here is the list of possible problematic reference found by the new validation
from api tooling:
The method java.lang.String.split(String) referenced in org.eclipse.ui.internal.net.NonProxyHostsComposite is not defined in bundle's required execution environment: J2SE-1.3

java.lang.String.split(String) has been added in 1.4.
Comment 1 Olivier Thomann CLA 2008-11-28 12:39:50 EST 
In fact the list is longer than that. This is from last night build.
The method java.lang.String.split(String) referenced in org.eclipse.ui.internal.net.NonProxyHostsComposite.promptForHost(String) is not defined in bundle's required execution environment: J2SE-1.3
The method java.lang.Boolean.toString(boolean) referenced in org.eclipse.ui.internal.net.ProxyEntriesLabelProvider.getColumnText(Object, int) is not defined in bundle's required execution environment: J2SE-1.3
The type java.net.URISyntaxException referenced in org.eclipse.ui.internal.net.ProxyEntryDialog.updateStatus() is not defined in bundle's required execution environment: J2SE-1.3
The type java.net.URI referenced in org.eclipse.ui.internal.net.ProxyEntryDialog.updateStatus() is not defined in bundle's required execution environment: J2SE-1.3
The constructor URI(String) referenced in org.eclipse.ui.internal.net.ProxyEntryDialog.updateStatus() is not defined in bundle's required execution environment: J2SE-1.3
Comment 2 Szymon Brandys CLA 2008-12-10 10:31:48 EST 
Pawel, you can use a similar fix to the one for bug 255814. Thus you will get the credit for both :-)
Comment 3 Pawel Pogorzelski CLA 2008-12-12 07:05:05 EST 
Created attachment 120304 [details]
Patch_v01
Comment 4 Pawel Pogorzelski CLA 2008-12-12 07:25:22 EST 
Created attachment 120309 [details]
Patch_v02

A more elegant solution which uses StringUtil class from org.eclipse.core.net plugin. This class will be available when bug 255814 is fixed.
Comment 5 Tomasz Zarna CLA 2008-12-16 05:58:01 EST 
Released to HEAD.