Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 255805 - Missing commit rights to new PDE UI location
Summary: Missing commit rights to new PDE UI location
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: CVS (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Webmaster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-19 10:06 EST by Curtis Windatt CLA
Modified: 2008-11-21 10:16 EST (History)
4 users (show)

See Also:
caniszczyk: review+
darin.eclipse: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2008-11-19 10:06:11 EST 
For bug 253724, a new folder structure was created for the PDE plugins.  Everything was working until today when I tried committing to the test plugin.  It appears that I have lost my commit rights to the org.eclipse.pde.ui.tests bundle.

As a PDE UI committer I should have commit rights to all of the bundles in the pde/ui folder:

pde.core
pde.junit.runtime
pde.ui
pde.ui.templates
pde.ui.tests
ui.views.log

So far I have only tested committing to pde.ui successfully and pde.ui.tests unsucessfully.

Thanks!
Comment 1 Denis Roy CLA 2008-11-21 09:23:18 EST 
The file ownership and permissions have not changed with the move:

/cvsroot/eclipse/pde/ui # ls -l
total 3
drwxrwsr-x+ 17 dejan   pde-core     760 Nov 17 14:01 org.eclipse.pde.core
drwxrwsr-x+  5 wmelhem pde-ui       368 Nov 11 19:36 org.eclipse.pde.junit.runtime
drwxrwsr-x+  8 dejan   pde-ui       456 Nov 13 09:41 org.eclipse.pde.runtime
drwxrwsr-x+ 24 dejan   pde-ui       984 Nov 14 15:53 org.eclipse.pde.ui
drwxrwsr-x+ 12 jeff    pde-ui       568 Nov 11 19:38 org.eclipse.pde.ui.templates
drwxrwsr-x+ 13 dejan   pde-ui-tests 568 Nov 11 19:38 org.eclipse.pde.ui.tests
drwxrwsr-x+  6 jeff    pde-ui       360 Nov 11 19:37 org.eclipse.ui.views.log

pde-ui-tests:*:8171:cwong,dejan,jeem,kkolosow,sdimitro,vlad,wmelhem,kmoir,janeklb,bbauman,mpawlowsk,caniszczyk

You were not removed from the pde-ui-tests group, and "egrep 'author.*cwindatt' * -R" returns no results in org.eclipse.pde.ui.tests, so I'm not convinced you were able to commit there before.

From here, please CC your project lead for a +1 to be added to pde-ui-tests.
Comment 2 Curtis Windatt CLA 2008-11-21 09:32:24 EST 
That's interesting :)  My previous changes to the tests must have been contributed through patches then.

Adding Chris and Darin as reviewers.
Comment 3 Chris Aniszczyk CLA 2008-11-21 09:52:51 EST 
+1
Comment 4 Darin Wright CLA 2008-11-21 09:55:35 EST 
+1 test away!
Comment 5 Denis Roy CLA 2008-11-21 10:11:02 EST 
I've added you to the group.  You'll need to refresh your SSH session for it to take effect (restart Eclipse)
Comment 6 Curtis Windatt CLA 2008-11-21 10:16:45 EST 
Works great, thanks Denis!