Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 255804 - Wrong API problem (illegally implements interface via sub-interface)
Summary: Wrong API problem (illegally implements interface via sub-interface)
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: API Tools (show other bugs)
Version: 3.5   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 230189
Blocks:
  Show dependency tree
 
Reported: 2008-11-19 10:02 EST by Markus Keller CLA
Modified: 2008-11-20 14:45 EST (History)
3 users (show)

See Also:

Attachments
proposed fix and updated test suite (6.63 KB, patch)
2008-11-20 12:08 EST, Michael Rennie CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2008-11-19 10:02:44 EST 
I20081118-1720 (including fix for bug 230189)

In HEAD, we have the following API problem:

AbstractTemplatesPage illegally implements IPage via ITemplatesPage in org.eclipse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/templates/AbstractTemplatesPage.java

Here's the type declaration:
public abstract class AbstractTemplatesPage extends Page implements ITemplatesPage { ... }

=> AbstractTemplatesPage should not be flagged, since it also implements IPage via superclass Page, and that path is legal.
Comment 1 Darin Wright CLA 2008-11-20 10:29:35 EST 
I see the problem by checking out org.eclipse.ui.workbench.texteditor as well.
Comment 2 Michael Rennie CLA 2008-11-20 12:08:18 EST 
Created attachment 118380 [details]
proposed fix and updated test suite

The problem was that we were not inspecting the complete interface hierarchy for parent classes, we were only looking at direct implementation for parent classes.
Comment 3 Michael Rennie CLA 2008-11-20 12:13:57 EST 
applied patch to HEAD

please verify Darin W
Comment 4 Darin Wright CLA 2008-11-20 14:45:05 EST 
Verified.