Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 255630 - SWT.UNDERLINE_LINK color too dark
Summary: SWT.UNDERLINE_LINK color too dark
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Felipe Heidrich CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-18 07:18 EST by Dani Megert CLA
Modified: 2013-02-12 08:29 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2008-11-18 07:18:01 EST
I20081118-0800.

The native/default color used for SWT.UNDERLINE_LINK is too dark.

Now, I can see that it is the same color as in some of the WindowsXP dialogs (e.g. 'Automatic Updates' config dialog) but compared to IE, Mozilla and what we used in the text editor so far it is way too dark.

BTW: Any idea how I could change the WindowsXP hyperlink color?
Comment 1 Steve Northover CLA 2008-11-18 11:45:46 EST
> I can see that it is the same color as in some of the WindowsXP dialogs

That means that the color is "right".
Comment 2 Dani Megert CLA 2008-11-18 11:48:45 EST
>That means that the color is "right".
Yes, it is technically "right" and even OK when used in dialogs but it is unexpected for a link inside StyledText where people rather like to see the known color from the browsers.
Comment 3 Steve Northover CLA 2008-11-18 11:52:33 EST
Is it darker than IE?
Comment 4 Felipe Heidrich CLA 2008-11-18 12:18:42 EST
(In reply to comment #3)
> Is it darker than IE?

Yes.
IE: 0,51,153
TextLayout: 0,0,128  <- this is the color SysLink uses and the color returned by GetSysColor (OS.COLOR_HOTLIGHT)

Not sure why they are different, maybe the SysLink color is meant the be used against a widget background color (dark gray) while IE color is meant to be used against a white background.
Comment 5 Dani Megert CLA 2008-11-19 02:56:36 EST
>Yes.
>IE: 0,51,153
On my system with Windows Classic style IE has 0,0,153 (same as Firefox).
Comment 6 Dani Megert CLA 2013-02-12 08:29:55 EST
Closing as WORKSFORME: under Windows 7 the color is now the same for the hyperlinks in the editor, IE and Windows dialogs and it is the same as returned by the new SWT.COLOR_LINK_FOREGROUND API from bug 181592 (0,102,204).