Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 255556 - [Contributions] Extension point org.eclipse.ui.popupMenus has a typo: java.lang.object
Summary: [Contributions] Extension point org.eclipse.ui.popupMenus has a typo: java.la...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.1   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 3.6 M5   Edit
Assignee: Paul Webster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-17 14:21 EST by Stephan Herrmann CLA
Modified: 2010-01-26 09:14 EST (History)
0 users

See Also:

Attachments
patch (728 bytes, patch)
2009-12-07 13:48 EST, Stephan Herrmann CLA 		pwebster: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2008-11-17 14:21:57 EST 
Build ID: M20080911-1700

I found this in org.eclipse.ui's popupMenus.exsd:

<element name="objectContribution">
  ...
  <complexType>
    <attribute name="objectClass" type="string" use="required">
      <annotation>
        <documentation>
          a fully qualified name of the class or interface that all objects in the selection must subclass or implement.
        </documentation>
        <appinfo>
          <meta.attribute kind="java" basedOn="java.lang.object"/>
        </appinfo>
      </annotation>
    </attribute>
    ...

In my JRE the class java.lang.object is unknown ;-)

This occurred in the context of bug 61185, where 
javaProject.findType(superTypeName) unexpectedly returns
null. In this context it doesn't cause user-visible harm,
but here we're simply lucky because super type Object
means exactly the same as not giving a valid super type...
Comment 1 Stephan Herrmann CLA 2009-01-20 11:00:38 EST 
Any reason for not changing "object" to "Object"? 
;-)
Comment 2 Stephan Herrmann CLA 2009-05-14 09:09:35 EDT 
Is this just too trivial to be fixed?
Comment 3 Paul Webster CLA 2009-05-14 09:35:15 EDT 
(In reply to comment #2)
> Is this just too trivial to be fixed?

We do try and fix these kinds of bugs, (usually 7-12 per milestone).  It requires time, that's all, and now in the endgame I have a disappearing menu item that takes priority :-)

PW
Comment 4 Stephan Herrmann CLA 2009-12-04 20:12:18 EST 
Wow, this tiniest littlest bug is past its first birthday ;-)
Comment 5 Paul Webster CLA 2009-12-07 08:03:55 EST 
(In reply to comment #4)
> Wow, this tiniest littlest bug is past its first birthday ;-)

popupMenus never gets touched (and hence never gets fixed :-)

Feel free to attach a patch (I always search for bugs with patches when looking for the little things to fix)

PW
Comment 6 Stephan Herrmann CLA 2009-12-07 13:48:17 EST 
Created attachment 153949 [details]
patch

hooray, the smallest patch I'll ever submit ;-)
Comment 7 Paul Webster CLA 2010-01-20 12:57:05 EST 
Thank you for your patience (sorry about that).

PW
Comment 8 Paul Webster CLA 2010-01-26 09:14:52 EST 
In I20100126-0100
PW