Community
Participate
Working Groups
Created attachment 117768 [details] The warning message Build ID: I20081030-1917 Steps To Reproduce: 1. Try to import a project from a zip file 2. If the project is already available in the workspace, the wizard shows a warning - which doesn't say the project name More information: I encountered it quite a few times. I would try to import a project attached to a bug and the wizard would simply say it already exists. I have no clue of which project that is, because I have quite a few from the bugzilla. Suggestion: Instead of hiding the project, the wizard can probably show the project/projects in the below table. The checkbox can be unchecked & disabled, so that the user can't select it anyway. The warning also can be displayed along to make it clear for the user who is wondering why they are greyed out.
Suggestion: > Instead of hiding the project, the wizard can probably show the > project/projects in the below table. The checkbox can be unchecked & disabled, > so that the user can't select it anyway. The warning also can be displayed > along to make it clear for the user who is wondering why they are greyed out. > +1, I have been confused by this dialog many times, I think this is important to fix, and I like your suggestion.
Created attachment 118237 [details] Fixed UI The project that is already in the workspace will be greyed out and cannot be selected. Also the warning message is displayed.
My 2 cents: I like the idea, but I'd like to see rather 'disable' then 'gray out'. Disabled controls are easily recognizable and will not confuse the user (grayed projects can or cannot be imported?). Note there is still a checkbox that appears to be selectable (and should be not, unless you are able to overwrite the project). But I'm afraid there is no such functionality in CheckBoxTreeViewer :-(
(In reply to comment #3) > My 2 cents: > I like the idea, but I'd like to see rather 'disable' then 'gray out'. Disabled > controls are easily recognizable and will not confuse the user (grayed projects > can or cannot be imported?). > Note there is still a checkbox that appears to be selectable (and should be > not, unless you are able to overwrite the project). > > But I'm afraid there is no such functionality in CheckBoxTreeViewer :-( > I wish disabling is supported by SWT. Since it didn't, I have to opt for this grayed out option. The selectable checkbox (for the first project) is because that project didn't exist in the workspace. If the project exists, then the user cannot check it.
Created attachment 118289 [details] Patch with corrected tests Patch attached. The functionality of the method getValidProjects is changed and so renamed to getProjectRecords. Tests are also updated to reflect the change
Maybe we could open RFE against SWT?
(In reply to comment #6) > Maybe we could open RFE against SWT? > Well, I too thought that. But its been raised before and closed as won't fix. https://bugs.eclipse.org/bugs/show_bug.cgi?id=145628
Created attachment 118339 [details] Another UI proposition I'd choose this direction...
Created attachment 118343 [details] modifiedPatch Prakash' patch changed to gray the font, not the background
(In reply to comment #8) > Created an attachment (id=118339) [details] > Another UI proposition > > I'd choose this direction... > I too like this way!
(In reply to comment #9) > Created an attachment (id=118343) [details] > modifiedPatch > > Prakash' patch changed to gray the font, not the background > > Patch attached. The functionality of the method getValidProjects is changed and > so renamed to getProjectRecords. Tests are also updated to reflect the change > I think this is almost ready to go in. Prakash, could you please update the tests so that they check the new getProjectRecords() similar to getValidProjects(). i.e. now we have to both check that all projects are there and that none of them have their conflicts flag set. PW
Created attachment 120289 [details] Patch with tests added Added new tests for the new getProjectRecords method
Created attachment 120290 [details] Test file Test archive that needs to go into /org.eclipse.ui.tests/data/org.eclipse.datatransferArchives
(In reply to comment #12) > Created an attachment (id=120289) [details] > Patch with tests added > > Added new tests for the new getProjectRecords method > Excellent. For testFindSingleZip() should we not be testing that those records returned do not contain the conflict flag set? PW
Created attachment 124162 [details] Patch v04 (In reply to comment #14) > Excellent. For testFindSingleZip() should we not be testing that those records > returned do not contain the conflict flag set? Added that check.
Trying to push this before UI freeze. Updating target to M6
(In reply to comment #15) > Created an attachment (id=124162) [details] > Patch v04 > Released to HEAD >20090223 Thanx, Prakash. PW
Verified in I20090310-0100
