Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 254996 - [Webapp] Infocenter: printing with mod_proxy
Summary: [Webapp] Infocenter: printing with mod_proxy
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.4.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.5 M5   Edit
Assignee: platform-ua-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 274944 320373 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-11-12 03:39 EST by Daniel Walter CLA
Modified: 2011-02-07 17:15 EST (History)
4 users (show)

See Also:

Attachments
Patch (1.00 KB, patch)
2009-01-13 18:53 EST, Chris Goldthorpe CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Walter CLA 2008-11-12 03:39:56 EST 
Build ID: M20080911-1700

Steps To Reproduce:
1. Navigate to an Infocenter that is behind Apache proxy (mod_proxy)
2. Select a topic from TOC
3. Select print->Print selected topic and all subtopics


More information:
Links in the page are absolute and are therefore ignored by mod_proxy. The links are pointing to 127.0.0.1:8888, which obviously cannot work. Images and CSS are missing due to these broken links.

Proposed solution: links should be made relative, as there is no reason the make them absolute
Comment 1 Denis Roy CLA 2009-01-13 09:23:56 EST 
We're getting this on help.eclipse.org too, as it's running behind mod_proxy.
Comment 2 Chris Goldthorpe CLA 2009-01-13 16:42:56 EST 
Targeting 3.5. If I can create a patch would you be able to test it? I have located the code in PrintData.java which is modifying the hrefs and it seems like it should be easy to fix. I don't have mod proxy set up on my machine so it would save me a lot of time if someone could test the fix.
Comment 3 Denis Roy CLA 2009-01-13 16:49:05 EST 
(In reply to comment #2)
> Targeting 3.5. If I can create a patch would you be able to test it?

If you can provide me a fixed JAR file that I can use to replace the 'broken' one, then I'll put it up on help.eclipse.org for testing.
Comment 4 Chris Goldthorpe CLA 2009-01-13 18:53:03 EST 
Created attachment 122476 [details]
Patch

This should fix the problem. What version of Eclipse are you using to run your infocenter?
Comment 5 Daniel Walter CLA 2009-01-14 07:32:55 EST 
(In reply to comment #4)
> This should fix the problem. 

This patch fixes it for me (org.eclipse.help.webapp_3.3.101.M20080805_34x). Thanks, Chris.
Comment 6 Chris Goldthorpe CLA 2009-01-14 12:30:18 EST 
Patch applied to HEAD, Fixed.
Comment 7 Chris Goldthorpe CLA 2009-05-07 13:15:07 EDT 
*** Bug 274944 has been marked as a duplicate of this bug. ***
Comment 8 Chris Goldthorpe CLA 2011-02-07 17:15:28 EST 
*** Bug 320373 has been marked as a duplicate of this bug. ***