Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 254801 - [pull up] allow to specify whether to use 'public' modifier when generating interface method
Summary: [pull up] allow to specify whether to use 'public' modifier when generating i...
Status: RESOLVED DUPLICATE of bug 141874
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-10 16:22 EST by arie CLA
Modified: 2009-03-06 05:34 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description arie CLA 2008-11-10 16:22:14 EST
Build ID: I20081030-1917

Steps To Reproduce:
create interface and a class implementing the interface.
add methods to the class and then use refactor/pull-up.
Notice that if method has a reference to a private variable the refactor will change that to non-private (package scope).


More information:
Also, generated method in the interface include the public modifier even though not needed (and should be avoided).
Comment 1 Dani Megert CLA 2008-11-13 04:13:40 EST
>if method has a reference to a private variable the refactor will
>change that to non-private (package scope).
This is bug 188595.

>Also, generated method in the interface include the public modifier even though
>not needed (and should be avoided).
That's a matter of style. We should allow to configure this. Using this bug for that feature request.
Comment 2 Markus Keller CLA 2009-03-06 05:34:04 EST

*** This bug has been marked as a duplicate of bug 141874 ***