Community
Participate
Working Groups
When top-level elements are set to working sets, the most obvious usage of this would be to show all of the working sets defined. This is currently not supported. The user can configure PE to show all *current* working sets, but as new working sets are created, for example, when checking out sets of projects code from an SCM system, the user must constantly reconfigure the view to show all working sets again. I propose that if all of the current sets are selected (in the configure dialog), and the user presses OK, then this should be persisted as the single choice "all" rather than as the list of the currently defined sets.
Automagically showing the new working set when all other working sets are already shown in the Package Explorer would not work for people who do have working sets they don't want to see in the Package Explorer. And it would provoke other bug reports from people who disable their first working set in the Package Explorer and then wonder why their new working sets are not shown any more. Would bug 227676 be OK for you as an alternative (always add working set to the Package Explorer when a working set is created in a new/import wizard)?.
Bug 227676 is confusing. The way it is worded, it assumes no one else is creating Java Working Sets. This assumption fails in my scenario since Team Concert is the one creating the Java WS, not the end user. Here are two more options: 1) Use a checkbox tree, with a root "All" treeitem. 2) Have an external checkbox which captures what the checked state should be for ALL newly created JWSs. A perfect example of this is the PDE Launch config page->Plug-ins Tab->"Add new workspace plug-ins to this launch configuration automatically" checkbox. I like #2. BTW, the "Select All" button should select everything in the list, and enable this new option. It would be great to see this fixed in the maintenance stream. Of course you couldn't add the new UI in the maintenance stream due to NLS, etc., but how about just pretending that the setting exists and the value is always TRUE. In other words, fix bug 227676, but change the wording to be "the package explorer should listen for newly created java working sets and automatically set them to selected". Ok, so really, I'm asking to reword 227676 and target for 3.4.x, and target this bug (specifically, option 2 in this comment) for 3.5.
*** Bug 227676 has been marked as a duplicate of this bug. ***
Having a 'show all' flag is overkill. We should simply update the Package Explorer when a new working set is created - like we do when one is removed. This is feature work which will not go into a 3.4.x stream. When fixing this we also need to get rid of the dialog that we show when creating a new working set via the 'New Java Working Set' wizard.
Interestingly , when a new java project is created and has to be assigned to a working set using the context menu (Assign Working sets ..) , the dialog shows only the active working sets and not "all" working sets. So there's no way the user can select one of the non-active or removed working sets! If an attempt is made to create an existing working set , an error is shown that it already exists but there's no way for the user to select that working set other than reconfiguring that working set to be active, and then assigning the project to it. Since assigning working sets this way (using context menu) makes it automatically active and shows up in the PE , I suggest 'all' working sets should be shown in the Working Set Assignment dialog.
>So there's no way the user can select one of the non-active or removed working >sets! Note that there's a check box at the bottom of the dialog where you can choose to show the working sets that are currently not visible in the Package Explorer. And there's also a link to configure the Package Explorer Working sets. >Since assigning working sets this way (using context menu) makes it >automatically active and shows up in the PE Nope it does not and should not. Only when creating a new one it does automatically appear in the dialog and in the Package Explorer. The dialog is meant to quickly assign projects to working sets that are already visible in the Package Explorer i.e. it assumes that the Package Explorer working sets are configured as desired.
>Only when creating a new one it does >automatically appear in the dialog and in the Package Explorer. Now, there's a different bug in that dialog: when the user chooses to see all working sets and then checks one of them, it should of course also appear in the Package Explorer. Filed bug 256867 to track that.
Created attachment 120824 [details] Fixed. Activate newly added working sets , show in PE.
Patch is good (I only fixed the end of line comment with the @since 3.5 tag). Committed to HEAD. Available in builds >= I20090106-0800.
Verified in I20090127-0100.
*** Bug 178585 has been marked as a duplicate of this bug. ***
