This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 253900 - Audit is double checking ends!
Summary: Audit is double checking ends!
Status: RESOLVED WONTFIX
Alias: None
Product: Tigerstripe (Archived)
Classification: Technology
Component: Core (show other bugs)
Version: 0.4M0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.4M0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-05 07:31 EST by Richard Craddock CLA
Modified: 2011-05-18 14:30 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Richard Craddock CLA 2008-11-05 07:31:13 EST 
When an end of an Association is not a valid type, the auditor is throwing two errors:

one that its not a known type and 
one that the end type is "not suitable"
Comment 1 Richard Craddock CLA 2008-11-05 07:34:08 EST 
problem is in AssociationEnd.java

public static boolean isSuitableType(IType type){
		if (type.isArtifact()){
			if (suitableTypes == null)
				loadSuitableTypes();
			IAbstractArtifact typeArtifact = type.getArtifact();
			if (suitableTypesList.contains(typeArtifact.getClass())){
				return true;
			}
		}
		return false; 
	}

So if the type is not an Artifact it Barfs....

But how do we tell if its not even a known type - that's a java check...
Comment 2 Chris Hartley CLA 2008-11-05 16:28:42 EST 
This should not occur that frequently that I see it as a problem.
Comment 3 Navid Mehregani CLA 2011-05-18 14:30:40 EDT 
As long as the user is presented with the correct error message, I think it's fine.  Not really worth getting rid of second error message.