253696 – Change access modifiers in BuildpathsBlock

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 253696 - Change access modifiers in BuildpathsBlock

Summary: Change access modifiers in BuildpathsBlock

Status:	RESOLVED FIXED

Alias:	None

Product:	DLTK
Classification:	Technology
Component:	Common (show other bugs)
Version:	1.0
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	dltk.common-inbox
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2008-11-04 09:07 EST by Eden Klein
Modified:	2010-06-11 06:28 EDT (History)
CC List:	3 users (show)

See Also:

Attachments
change access modifiers patch (2.39 KB, patch) 2008-11-04 09:07 EST, Eden Klein	alex.panchenko: iplog+	Details \| Diff
access modifiers patch (2.31 KB, patch) 2008-11-06 07:36 EST, Eden Klein	alex.panchenko: iplog+	Details \| Diff
extensibility patch (7.62 KB, patch) 2008-11-12 09:49 EST, Eden Klein	alex.panchenko: iplog+	Details \| Diff
Wizard buttons patch (3.05 KB, text/plain) 2008-11-17 09:19 EST, Eden Klein	alex.panchenko: iplog+	Details
Image Provider patch (924 bytes, text/plain) 2008-11-18 06:55 EST, Eden Klein	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eden Klein

2008-11-04 09:07:36 EST

Created attachment 116935 [details]
change access modifiers patch

The purpose of BuildpathsBlock is obviously to be extended since it is abstract.
The problem is that most of its fields are private, which is kind of problematic. The attached patch changes the fields access modifiers to protected, so that it is easier to extend and modify the current block functionality.

Comment 1 Roy Ganor

2008-11-04 09:47:10 EST

fixed in CVS

Comment 2 Eden Klein

2008-11-06 07:35:25 EST

Thanks for the quick change,
there are a few additional access modifiers changes we need in order to extend the buoldpath functionality. i will attach the relevant patch

Comment 3 Eden Klein

2008-11-06 07:36:03 EST

Created attachment 117186 [details]
access modifiers patch

Comment 4 Alon Peled

2008-11-06 07:46:37 EST

fixed in CVS

Comment 5 Eden Klein

2008-11-12 09:49:24 EST

Created attachment 117665 [details]
extensibility patch

Hi,
i am adding an additional patch that enables further extensibility for the include paht block (enables changing the tabs titles and changing more access modifiers to protected)

Comment 6 Roy Ganor

2008-11-13 04:38:08 EST

fixed in head

Comment 7 Eden Klein

2008-11-17 09:19:17 EST

Created attachment 118046 [details]
Wizard buttons patch

This patch enables customization of the wizard buttons

Comment 8 Nir Cohen

2008-11-17 10:14:52 EST

commited patch : https://bugs.eclipse.org/bugs/attachment.cgi?id=118046
on behalf of Eden

NirC

Comment 9 Eden Klein

2008-11-18 06:55:10 EST

Created attachment 118127 [details]
Image Provider patch

enable extensibility of the image (label)  provider