Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 253076 - [UA] Javadoc erroneous for CtxHelp model classes (and perhaps some others)
Summary: [UA] Javadoc erroneous for CtxHelp model classes (and perhaps some others)
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 3.5 M4   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 241145
Blocks:
  Show dependency tree
 
Reported: 2008-11-01 15:46 EDT by Benjamin Cabé CLA
Modified: 2008-12-01 10:31 EST (History)
2 users (show)

See Also:


Attachments
patch against brand new org.eclipse.pde.ua.core plug-in (129.79 KB, patch)
2008-11-30 17:56 EST, Benjamin Cabé CLA
caniszczyk: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Cabé CLA 2008-11-01 15:46:46 EDT
When the patch attached to bug 241145 will have been committed, it would be cool to fix errors in some of the UA core's classes.
More specifically, almost every class in org.eclipse.pde.internal.ua.core.ctxhelp.text refer to toc models :

public class CtxHelpTopic extends CtxHelpObject {

	private static final long serialVersionUID = 1L;

	public CtxHelpTopic(CtxHelpModel model) {
		super(model, ELEMENT_TOPIC);
	}

	/* (non-Javadoc)
-->	 * @see org.eclipse.pde.internal.core.text.toc.TocObject#canBeParent()
	 */
	public boolean canBeParent() {
		return false;
	}


I will do this as soon as the patch gets integrated
Comment 1 Curtis Windatt CLA 2008-11-03 09:32:29 EST
Thanks.
Comment 2 Benjamin Cabé CLA 2008-11-30 17:56:45 EST
Created attachment 119101 [details]
patch against brand new org.eclipse.pde.ua.core plug-in

everything should be much cooler that way!
Not only I fixed the issue described in comment #0, but I also changed a lot of references to org.eclipse.pde.internal.core.* classes which have now moved to org.eclipse.pde.internal.ua.core.*
Comment 3 Chris Aniszczyk CLA 2008-12-01 10:30:55 EST
done.

Thanks Benjamin!

> 20091201