Community
Participate
Working Groups
The VEX Editor's Document contribution is always active even if the editor isn't open. This should only appear when the editor is opened, and it should be converted to the org.eclipse.ui.menus extension point and command/handler framework instead of action framework. This will allow easier adopter extension and contributions.
CCing Holger on this as well.
Created attachment 152801 [details] Fix for bug 252628 and bug 251488 Patch includes following changes: - Actions converted to command handlers - Document and context menu contributed via "org.eclipse.ui.menus" (see bug 251488) - Enablement/visibility declaratively managed by "org.eclipse.ui.services" - Naming and placing of menu items aligned with Eclipse UI convention (e.g. in contrast to documents/files which are created with 'New...' and deleted with 'Delete' smaller parts are "Add"ed and "Remove"d; Document and context menu rearranged) - Refactoring to avoid duplicated code (e.g. by introducing some abstract handlers) Because this patch probably exceeds the 250 lines IP log limit I guess I have to answer the three IP log questions: > 1. Did he authored 100% of the content Yes. (as individual) > 2. Does he have the rights to donate the content to Eclipse Yes. (I am the only author.) > 3. Does he contribute the content under the EPL Yes. (New files contain EPL header.)
This patch looks good. Because of the size and the fact that committer voting will end later today. I'm going to hold off on applying the patch for now. Depending on how quick you get your committer paperwork completed will be a big factor in how quickly we get this included. The reason to hold off is that I think it will take IP about as long to review the patch as it will to get the paperwork and done and complete.
Oh and in order to test some of this, you may have to create some Mocks so that you can test the functionality of the handlers. Might also want to go on IRC and ask either remey or paul webb how to go about unit testing these handlers.
(In reply to comment #4) To fix this bug I have not changed any algorithm of an action/handler but moved bigger parts of code to new classes without knowledge of the algorithm in detail. So I like to write UI tests as separate task. Maybe making the Vex widget SWTBot ready could be also an alternative.
Assigning to you Holger since your paper work is now complete. Welcome aboard and congrats. Make sure you subscribe to the wtp-incubator-dev mailing list.
Patch applied
Closing resolved bugs.
Moved to Mylyn Docs Vex.
