This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 252380 - Update logging data manager in demo to use TPTP plugin
Summary: Update logging data manager in demo to use TPTP plugin
Status: RESOLVED WORKSFORME
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Cosmos (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: ---   Edit
Assignee: Ramesh CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-28 10:54 EDT by David Whiteman CLA
Modified: 2012-01-03 13:47 EST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Whiteman CLA 2008-10-28 10:54:58 EDT
Currently the logging data manager packages the CBE jar directly.  We need to change this to instead bundle the TPTP plugin that is used to distribute the CBE jar.  This will be a change to the build, but will also involve ensuring any path changes are made so that the jar file is located within the newly bundled plugin.

This is required because Eclipse IP rules state that you can prereq an entire EPL plugin without need for approval, but not just an individual jar file from an EPL plugin.

I created this defect because it is easier to track the work this way rather than using email.
Comment 1 Hubert Leung CLA 2008-10-28 11:52:22 EDT
The logging data manager is not packaging the entire plugin from TPTP because it is not executing in the eclipse plugin environment.  It is a web service.  We need to put the jar file in the lib directory of the web service.

The org.eclipse.tptp.platform.logging.events plugin is packaged in an expanded form, i.e it is a directory with several jar files in the plugin directory.  The reason is for the anticipation of the binary being used in non-eclipse environments (e.g. the agent controller).  

I think one reason why we are asked to package the entire plugin is to ensure we ship the legal notices and about.html with the binary.  Can you ask the Eclipse legal team if it is permissible to redistribute a jar file that only contain EPL code found in a TPTP plugin with its associated legal files (such as about.html).  We will clearly indicate the file is not modified and the license is EPL.  

David, can you clarify the redistribution restrictions with the Eclipse legal team?  
Comment 2 David Whiteman CLA 2008-10-28 12:31:57 EDT
(In reply to comment #1)
> David, can you clarify the redistribution restrictions with the Eclipse legal
> team?  

I will try to ask, though the IP team is in "super stealth" mode this week as they are trying to make headway on a huge CQ and are ignoring most communication.  Maybe I can tag it with the special "urgent" flag to get this some attention. 

Comment 3 David Whiteman CLA 2008-10-28 12:41:44 EDT
(In reply to comment #2)
> I will try to ask, though the IP team is in "super stealth" mode this week as
> they are trying to make headway on a huge CQ and are ignoring most
> communication.  Maybe I can tag it with the special "urgent" flag to get this
> some attention. 

I sent the email.  Will post back here with the response I get.

Comment 4 David Whiteman CLA 2008-10-28 13:56:35 EDT
From Eclipse IP:
> If it’s all org.eclipse.* and all EPL, then you don’t need a CQ.  
>  
> We need CQs for third party code.

This was in reference to JAR files that are all EPL, so it does not have to be a complete plugin.

Looks like we are totally in the clear, as long as the about.html for the logging data manager indicates that the CBE jar is EPL.  Can someone please confirm this?
Comment 5 David Whiteman CLA 2008-10-28 16:16:58 EDT
I have learned there are 2 jar files, not one.  They are tlcbe101.jar and tlcore.jar.  They are both EPL and are both ok to redistribute.  Ruth has already updated the IP log for these.
Comment 6 David Whiteman CLA 2008-10-28 16:53:01 EDT
About.html files haven't been added yet; that's bug 229078.  Therefore this issue is closed with nothing to do!