Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 252086 - [Viewers] Text compare is not visible when editor background color is set to gray
Summary: [Viewers] Text compare is not visible when editor background color is set to ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.5   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.5 M5   Edit
Assignee: Pawel Pogorzelski CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-25 06:38 EDT by Frederic Fusier CLA
Modified: 2009-06-02 06:57 EDT (History)
2 users (show)

See Also:


Attachments
Invisible text in the compare editor (19.89 KB, image/jpeg)
2008-10-25 06:38 EDT, Frederic Fusier CLA
no flags Details
JUnit failing test comparison becomes unusable (46.70 KB, image/jpeg)
2008-11-05 09:20 EST, Frederic Fusier CLA
no flags Details
Patch (1.71 KB, patch)
2009-01-19 09:09 EST, Pawel Pogorzelski CLA
pawel.pogorzelski1: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Frederic Fusier CLA 2008-10-25 06:38:13 EDT
Created attachment 116128 [details]
Invisible text in the compare editor

Using build  I20081021-0905.

I changed the background color of my editors to gray. Now, when I try to compare text files, text is no longer visible in the compare editor as shown in the attached snapshot...
Comment 1 Frederic Fusier CLA 2008-11-05 09:20:08 EST
Created attachment 117077 [details]
JUnit failing test comparison becomes unusable
Comment 2 Frederic Fusier CLA 2008-11-05 09:22:30 EST
Would it be possible to fix this issue? It's definitely annoying especially while trying to debug failing tests as shown in the last attachment!

I do not want to change my preferences on all my workspaces (more than 50 dispatched on 4 machines!)
Comment 3 Szymon Brandys CLA 2008-11-05 11:01:44 EST
The fix for bug 80213 exposed unexpected behavior in the compare editor when changing the background color. When the background color is changed, the font color is changed at the same time and they both are almost the same.

I'm on it.
Comment 4 Pawel Pogorzelski CLA 2009-01-15 10:03:13 EST
Frederic, will providing a preference for the text colour will fix the problem for you? As I understand correctly now there isn't such an option.

Bug 80213 as Szymon mentioned made compare editor aware of background colour set in preferences. We cannot roll this change back sine old behaviour was invalid.
Comment 5 Frederic Fusier CLA 2009-01-16 04:31:31 EST
(In reply to comment #4)
> Frederic, will providing a preference for the text colour will fix the problem
> for you? As I understand correctly now there isn't such an option.
> 
> Bug 80213 as Szymon mentioned made compare editor aware of background colour
> set in preferences. We cannot roll this change back sine old behaviour was
> invalid.
> 
I do not think a new preference is necessary. In 3.4 the text color was black and everything was fine to me. The problem comes from the fact that the text color seems to have been changed to gray since 3.5...
Comment 6 Frederic Fusier CLA 2009-01-16 04:43:29 EST
FYI, this didn't happen with 3.5M2 (I20080918-0100). This may be helpful to identify which code changes broke this functionality...
Comment 7 Pawel Pogorzelski CLA 2009-01-19 09:09:41 EST
Created attachment 122935 [details]
Patch

Tomasz, please review it.
Comment 8 Tomasz Zarna CLA 2009-01-19 09:20:34 EST
(In reply to comment #5)
> I do not think a new preference is necessary. In 3.4 the text color was black
> and everything was fine to me. The problem comes from the fact that the text
> color seems to have been changed to gray since 3.5...

Right, there is no need for a new pref. The issue was caused by the fact that we set the same color for background and text in text compare. Patch from Pawel fixes the problem. The patch is in HEAD.