This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 252057 - NPE when adding a block comment
Summary: NPE when adding a block comment
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsd (show other bugs)
Version: 3.0.3   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: 3.0.5   Edit
Assignee: Wini Mark CLA
QA Contact: Valentin Baciu CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-24 15:29 EDT by Valentin Baciu CLA
Modified: 2009-05-14 01:41 EDT (History)
0 users

See Also:

Attachments
Stack trace (9.46 KB, text/plain)
2008-10-24 16:40 EDT, Valentin Baciu CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Valentin Baciu CLA 2008-10-24 15:29:44 EDT 
Steps to reproduce the NPE:
- create the XML Examples project
- open GolfCountryClub.xsd
- ensure the editor is in source mode
- in the outline view select the EmployeeType complex type
- in the source editor, with the mouse drag and select the entire markup for the EmployeeType
- use the top menu Source->Add block comment

A dialog pops up and a few entries with NPEs are added to the PDE log. See the attached stack trace.

Same behaviour in 3.0.3 so this is not a regression in 3.1 but some old problem undetected until now.
Comment 1 Valentin Baciu CLA 2008-10-24 16:40:08 EDT 
Created attachment 116110 [details]
Stack trace
Comment 2 Valentin Baciu CLA 2009-05-04 11:47:49 EDT 
Wini, I can see this problem with the latest M-3.0.5-20090501163713. 
Please investigate today.
Comment 3 Wini Mark CLA 2009-05-05 11:47:28 EDT 
I got the M-3.0.5-20090501163713 driver and can reproduce the problem. 

The NPE is actually fixed by Bug 156564. Once I apply the patch, I can do the "Add block comment' without seeing any NPE and the outline view is refreshed correctly. 

The fix for Bug 156564 was originally dropped into WTP 3.1 200904230645 build. We may need to put it in WTP 3.0.5 stream as well.
Comment 4 Valentin Baciu CLA 2009-05-05 20:07:01 EDT 
Fixed indirectly as part of fixing bug 275087.
Comment 5 Valentin Baciu CLA 2009-05-14 01:41:58 EDT 
Closing.