This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 251979 - build/classes is decorated as JS folder
Summary: build/classes is decorated as JS folder
Status: CLOSED FIXED
Alias: None
Product: JSDT
Classification: WebTools
Component: General (show other bugs)
Version: 3.0.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.0.3   Edit
Assignee: Phil Berkland CLA
QA Contact: Phil Berkland CLA
URL:
Whiteboard: PMC_approved
Keywords:
: 252417 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-10-24 05:36 EDT by Kaloyan Raev CLA
Modified: 2010-03-03 11:15 EST (History)
3 users (show)

See Also:
david_williams: pmc_approved+
berkland: pmc_approved? (raghunathan.srinivasan)
berkland: pmc_approved? (naci.dai)
deboer: pmc_approved+
berkland: pmc_approved? (neil.hauge)
berkland: pmc_approved? (kaloyan)

Attachments
screenshot (12.99 KB, image/png)
2008-10-24 05:36 EDT, Kaloyan Raev CLA 		no flags Details
patch (1.45 KB, patch)
2008-10-28 13:15 EDT, Phil Berkland CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2008-10-24 05:36:55 EDT 
Created attachment 116026 [details]
screenshot

Build id: M-3.0.3-20081023125735

See the attached screenshot. In EJB and EJB Client project the build/classes directory is decorated as JS folder. This somehow prevents the folder to be hidden by the "Java output folders" filter.

There is no significant functional breakage, but I mark this as major, because:
  - this is regression since 3.0.2
  - this is an UI change and the decorator is misleading
  - this breaks the "Java output folders" filter.
Comment 1 Phil Berkland CLA 2008-10-27 17:28:13 EDT 
It looks like this was caused by fix to 251979.  I would like to revert the fix for that bug, but am worried it will break the adopter.

This fix went in to 3.0.1, so 3.0.2 should have been broken.
Comment 2 Phil Berkland CLA 2008-10-27 17:30:29 EDT 
Wrong bug referenced in previous comment, this bug was caused by fix to 238772.
Comment 3 Phil Berkland CLA 2008-10-28 13:15:03 EDT 
Created attachment 116325 [details]
patch
Comment 4 Phil Berkland CLA 2008-10-28 13:18:18 EDT 
Figured out how to fix without reverting the previous fix.
The patch just adds an extra "if", rest of the change is formatting.

    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
Requested by Kayleyan.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 
no

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
JSDT Junit tests

    * Give a brief technical overview. Who has reviewed this fix? 


    * What is the risk associated with this fix? 
minimal.
Comment 5 Phil Berkland CLA 2008-10-28 17:40:19 EDT 
*** Bug 252417 has been marked as a duplicate of this bug. ***
Comment 6 Phil Berkland CLA 2008-10-29 13:26:48 EDT 
Applied the patch.
Comment 7 Kaloyan Raev CLA 2008-11-10 04:06:59 EST 
Verified with 3.0.3 RC3.