This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 251895 - JMX: Refactor and Internationalize INFO logs in WebLogic specific MBean functions
Summary: JMX: Refactor and Internationalize INFO logs in WebLogic specific MBean funct...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Michael OBrien CLA
QA Contact:
URL: http://wiki.eclipse.org/EclipseLink/D...
Whiteboard:
Keywords:
Depends on: 248748
Blocks:
  Show dependency tree
 
Reported: 2008-10-23 14:44 EDT by Michael OBrien CLA
Modified: 2022-06-09 10:08 EDT (History)
1 user (show)

See Also:


Attachments
Logging changes for WebLogicRuntimeServices (63.40 KB, patch)
2008-10-23 16:04 EDT, Michael OBrien CLA
no flags Details | Diff
Logging changes for WebLogicRuntimeServices (186.33 KB, patch)
2008-10-30 10:29 EDT, Michael OBrien CLA
no flags Details | Diff
eclipselink core patch (phase 1 - post code-review) (188.12 KB, patch)
2008-10-31 17:25 EDT, Michael OBrien CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael OBrien CLA 2008-10-23 14:44:09 EDT
The logging in weblogic.WebLogicRuntimeServices.java needs to be refactored and internationalized.

Current code:
    public void printAvailableConnectionPools() {
                getSession().getSessionLog().info("Pool Name = " + poolNames.next());
-->             [EL Info]: 2008.10.23 13:43:49.517--Thread(Thread[RMI TCP Connection(10)-10.156.52.98,5,RMI Runtime])--Pool Name = default (There is no English translation for this message.)

Refactored code:

The form
optional-->                AbstractSessionLog.getLog().log(SessionLog.INFO, "jmx_mbean_runtime_services_pool_name", poolNames.next());
preferred-->              ((AbstractSession)session).log(SessionLog.INFO, SessionLog.TRANSACTION, "jmx_mbean_runtime_services_pool_name",poolNames.next());

List of candidates
getSession().getSessionLog().info("Identity Map [" + className + "] does not exist");
getSession().getSessionLog().info("Identity Map [" + className + "] is empty");
getSession().getSessionLog().info("Key [" + cacheKey.getKey().toString() + "] => Value [" + cacheKey.getObject().toString());
getSession().getSessionLog().info("There are no Identity Maps in this session");
getSession().getSessionLog().info("Identity Map [" + registeredClassName + "] class = " + map.getClass());
getSession().getSessionLog().info("There are no Identity Maps in this session");
getSession().getSessionLog().info("There are no Identity Maps in this session");
getSession().getSessionLog().info("Identity Map [" + className + "] is initialized");
getSession().getSessionLog().info("There are no Identity Maps in this session");
getSession().getSessionLog().info("Identity Map [" + registeredClassName + "] is invalidated");
getSession().getSessionLog().info("Identity Map [" + className + "] is invalidated");
Comment 1 Michael OBrien CLA 2008-10-23 14:53:25 EDT
((AbstractSession)session).log(SessionLog.INFO,
SessionLog.TRANSACTION,
"jmx_mbean_runtime_services_pool_name",poolNames.next());

is preferable as it prints out the application session that the bean belongs to.

[EL Info]: 2008.10.23 14:49:21.900--ServerSession(18578566)--Thread(Thread[RMI TCP Connection(1)-10.156.52.98,5,RMI Runtime])--Pool Name = default
Comment 2 Michael OBrien CLA 2008-10-23 16:04:47 EDT
Created attachment 115981 [details]
Logging changes for WebLogicRuntimeServices
Comment 3 Michael OBrien CLA 2008-10-30 10:29:44 EDT
Created attachment 116517 [details]
Logging changes for WebLogicRuntimeServices
Comment 4 Michael OBrien CLA 2008-10-31 17:25:09 EDT
Created attachment 116659 [details]
eclipselink core patch (phase 1 - post code-review)

Reviewed as part of bug# 248748 by David Minsky.
In rev 2700
http://fisheye2.atlassian.com/changelog/eclipselink/?cs=2700
Comment 5 Michael OBrien CLA 2008-10-31 17:26:00 EDT
Regression Testing: OK (0,0) 
JPA:    [junit] Tests run: 1004, Failures: 0, Errors: 0, Time elapsed: 862.954 sec 
CORE:   [junit] Tests run: 6614, Failures: 0, Errors: 0, Time elapsed: 1,306.008 sec   
Comment 6 Eclipse Webmaster CLA 2022-06-09 10:08:41 EDT
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink