Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 251473 - [externalization] task list not restored after out of memory error
Summary: [externalization] task list not restored after out of memory error
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P1 normal (vote)
Target Milestone: 3.2.2   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-10-20 16:20 EDT by Steffen Pingel CLA
Modified: 2009-09-09 13:53 EDT (History)
1 user (show)

See Also:


Attachments
patch (6.91 KB, patch)
2009-09-09 13:48 EDT, Steffen Pingel CLA
no flags Details | Diff
mylyn/context/zip (52.19 KB, application/octet-stream)
2009-09-09 13:48 EDT, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2008-10-20 16:20:27 EDT
Eclipse was running unattended for a couple of days and ran out of heap space. After restarting the task list was not restored.

Contents of the backup repository:

-rw-r--r--   1 stp stp 1313067 2008-10-19 23:38 mylyn-v3-data-2008-10-19-233849.zip
-rw-r--r--   1 stp stp 1313095 2008-10-20 00:38 mylyn-v3-data-2008-10-20-003849.zip
-rw-r--r--   1 stp stp 1313257 2008-10-20 01:38 mylyn-v3-data-2008-10-20-013849.zip
-rw-r--r--   1 stp stp 1313127 2008-10-20 02:38 mylyn-v3-data-2008-10-20-023849.zip
-rw-r--r--   1 stp stp 1313247 2008-10-20 03:38 mylyn-v3-data-2008-10-20-033849.zip
-rw-r--r--   1 stp stp 1313230 2008-10-20 04:55 mylyn-v3-data-2008-10-20-043938.zip
-rw-r--r--   1 stp stp  199615 2008-10-20 05:39 mylyn-v3-data-2008-10-20-053903.zip
-rw-r--r--   1 stp stp   83994 2008-10-20 06:52 mylyn-v3-data-2008-10-20-065208.zip

It appears that at some point the task list could not be fully written to disk causing the backup size to degrade over time.
Comment 1 Robert Elves CLA 2009-02-27 19:55:43 EST
Don't suppose you still have any of those smaller backup files kicking around? Might be worth looking at the contents to see whats missing and/or what the tasklist contains.
Comment 2 Steffen Pingel CLA 2009-03-01 23:37:34 EST
Well, it's unpredictable when the backup fails. I am pretty sure the backup will simply stop adding files once it runs out of memory and close the file.
Comment 3 YiDao CLA 2009-04-01 02:07:23 EDT
(In reply to comment #1)
> Don't suppose you still have any of those smaller backup files kicking around?
> Might be worth looking at the contents to see whats missing and/or what the
> tasklist contains.
I think you are right!
Comment 4 Steffen Pingel CLA 2009-09-09 13:48:31 EDT
Created attachment 146789 [details]
patch
Comment 5 Steffen Pingel CLA 2009-09-09 13:48:35 EDT
Created attachment 146790 [details]
mylyn/context/zip
Comment 6 Steffen Pingel CLA 2009-09-09 13:53:45 EDT
The patch changes the backup operation so that it propagates exceptions which are now handled in the backup manager. In case of an exception during backup the corrupted backup file is deleted to avoid confusion. I have committed this to the service branch and head.