Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 251193 - closing the WorkbenchWindow causes the RectangleAnimation to fail
Summary: closing the WorkbenchWindow causes the RectangleAnimation to fail
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 247813 (view as bug list)
Depends on:
Blocks: 107753
  Show dependency tree
 
Reported: 2008-10-17 04:58 EDT by Krzysztof Daniel CLA
Modified: 2009-06-03 12:55 EDT (History)
1 user (show)

See Also:

Attachments
Proposed fix (835 bytes, patch)
2008-10-17 04:58 EDT, Krzysztof Daniel CLA 		no flags Details | Diff
Updated fix (1.32 KB, patch)
2008-10-17 05:48 EDT, Krzysztof Daniel CLA 		emoffatt: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Daniel CLA 2008-10-17 04:58:11 EDT 
Created attachment 115368 [details]
Proposed fix

This is because RectangleAnimation extends Job, which can be sheduled and executed after the WorkbenchWindow is closed.

I think it would be good to check in every step at least if the parent shell was not disposed.
Comment 1 Krzysztof Daniel CLA 2008-10-17 05:48:35 EDT 
Created attachment 115372 [details]
Updated fix

It seems that we have to add some kind of safety guard in more places.
Comment 2 Eric Moffatt CLA 2008-10-21 16:15:40 EDT 
Krzysztof, thanks for the patch. I'll apply it right away since it can't do any harm.

This does raise an interesting question though...why should -any- Job run after the eclipse session is closed ? (or is this defect specific to having multiple Workbench Windows open?)
Comment 3 Eric Moffatt CLA 2008-10-21 16:28:11 EDT 
I'm looking deeper into the issue; there are more than one type of renderer that needs to be updated so I'm looking for a common solution...good pickup though (it truly spams the log).
Comment 4 Eric Moffatt CLA 2008-10-22 15:04:53 EDT 
Committed in >20081022. Switched all code to use the new AnimationEngine then made it protect against shell disposal...

Krzysztof, kick this around if you want to see if it catches all of your scenarios...
Comment 5 Eric Moffatt CLA 2008-10-28 10:21:10 EDT 
Verified in I20081027-1300.
Comment 6 Laurent Marchal CLA 2009-01-29 06:15:21 EST 
*** Bug 247813 has been marked as a duplicate of this bug. ***