Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 251003 - [DataBinding] MultiValidator misses some dependencies
Summary: [DataBinding] MultiValidator misses some dependencies
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Matthew Hall CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 251267 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-10-15 15:43 EDT by Ovidio Mallo CLA
Modified: 2009-03-08 11:30 EDT (History)
1 user (show)

See Also:


Attachments
simple unit test illustrating the problem (2.20 KB, patch)
2008-10-15 15:49 EDT, Ovidio Mallo CLA
qualidafial: iplog+
Details | Diff
Includes Ovidio's test, one test of mine, and the fix (7.00 KB, patch)
2008-10-24 18:49 EDT, Matthew Hall CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ovidio Mallo CLA 2008-10-15 15:43:34 EDT
After computing the actual validation dependencies through a call to ObservableTracker#runAndMonitor(), the MultiValidator explicitly excludes the observables used internally (validationStatus, targets, ...) from those dependencies in order to prevent dependency loops.

Since the removal of the internal dependencies is done through the List#remove(Object) method, every observable whose equals() method matches one of the internal observables is excluded as well. This is mainly a problem with lists whose equals() method typically compares whether all elements are pairwise equal.

Instead, the internal observables should be removed by references from the tracked dependencies.
Comment 1 Ovidio Mallo CLA 2008-10-15 15:49:01 EDT
Created attachment 115186 [details]
simple unit test illustrating the problem
Comment 2 Matthew Hall CLA 2008-10-17 12:31:09 EDT
Waiting for bug 237857 before I tackle this
Comment 3 Matthew Hall CLA 2008-10-24 18:49:12 EDT
Created attachment 116121 [details]
Includes Ovidio's test, one test of mine, and the fix
Comment 4 Matthew Hall CLA 2008-10-24 18:50:25 EDT
Released to HEAD > 20081024
Comment 5 Matthew Hall CLA 2009-03-08 11:30:26 EDT
*** Bug 251267 has been marked as a duplicate of this bug. ***