Community
Participate
Working Groups
build 20021018 The Tag Configuration dialog has the top text too close to the top of the dialog abd a lot of white space in between. You may want to consider using the TitleAreaDialog as a superclass.
Created attachment 2342 [details] Proposed change to inherit from TitleAreaDialog. For some weird reason, the title does not show up in my GTK installation. Will investigate prior to going to commit.
Created attachment 2343 [details] Proposed change to inherit from TitleAreaDialog. For some weird reason, the title does not show up in my GTK installation. Will investigate prior to going to commit.
Fix released to HEAD
There are still a few problems: 1. The banner text doesn't wrap and can end up under the banner icon. At the default dialog setting on my machine, the end of the banner text couldn't be read. When working on dialogs, resize behaviour should always be checked for. 2. The banner icon is some basic icon. It should be the CVS icon. See "Checkout Into". 3. The title of the dialog should be renamed. It currently says, "Tag Configuration for Eclipse VCM". It should say, "Configure Branches and Versions" to match the menu action name.
Re: #1: We should report lack of wrapping to JFace. This may have been a stylistic decision on their part. Either way, we should shorten the sentence. We have the second line of the banner to use which *does* wrap.
SWT.WRAP works different ways on different platforms - frequently you have to put a /n in to get it to break where you want it to (sometimes it will only break on punctutation). Please pop by if you want more details/have case for me to look at.
General comment: It is true that making Label wrap consistently across platforms is pain, as wrap semantics is different on e.g. Windows and GTK, and there were very heated arguments betweem Steve and me about the right way to do it. The final understanding, however, was that it should be considered "done, working" now. More specific comment: The 'banner text wrapping' that Kevin mentioned, refers to titleLabel. Right now, it's created with SWT.LEFT style. The Tag Configuration Dialog displays a long title, and the discussion was about whether the official 'style guideline' is 'no long banners', or should the banner be wrapped.
I just talked to Tod, and the answer to the last question is: never wrap in titles.
Created attachment 3586 [details] Fixing 1 and 3
Re: 2. I looked which places where we use the big icons, and it appears that generally we use the big icons in wizards and don't use icons in dialogs (including the original TagConfigurationDialog). In fact, the wizards have specialized (wizard-by-wizard) icons, and it is not clear which of them would be appropriate for the TagCofigurationDialog. Therefore I propose removing the generic icon: protected Control createDialogArea(Composite parent) { setTitle(Policy.bind("TagConfigurationDialog.4")); //$NON-NLS-1$ + setTitleImage(null); Composite shell = new Composite(parent, SWT.NONE);
patches released to HEAD
There are strange white visual artifacts that appear at the top of the dialog on both Windows and GTK. It's probably related to the use of TitleAreaDialog.
Re: white visual artifacts: see bug 32839
*** This bug has been marked as a duplicate of 30646 ***
